Paths

Table of Contentst

Pass the file contents instead of the file path to `phutil_json_decode`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 24 2014, 1:41 AM.

Tags

None

Referenced Files

	F15495599: D9704.id23297.diff
	Sun, Apr 13, 5:08 AM

	F15494637: D9704.id23298.diff
	Sun, Apr 13, 12:54 AM

	F15493192: D9704.id.diff
	Sat, Apr 12, 9:39 PM

	F15490384: D9704.diff
	Fri, Apr 11, 4:50 PM

	F15483171: D9704.id23297.diff
	Wed, Apr 9, 10:23 AM

	F15472450: D9704.diff
	Sat, Apr 5, 1:47 PM

	F15467925: D9704.id23298.diff
	Thu, Apr 3, 6:23 PM

	F15416924: D9704.id23298.diff
	Mar 20 2025, 2:23 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC108a4dc9e6ca: Pass the file contents instead of the file path to `phutil_json_decode`.

Summary

See D9681#22.

Test Plan

Created an empty .git/arc/config file... no exception was thrown.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1353
Build 1353: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23297.Jun 24 2014, 1:41 AM

joshuaspence retitled this revision from to Pass the file contents instead of the file path to `phutil_json_decode`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 24 2014, 1:41 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1353: Diff 23297.Jun 24 2014, 1:42 AM

epriestley accepted this revision.Jun 24 2014, 2:01 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 24 2014, 2:01 AM

Closed by commit rARC108a4dc9e6ca (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

workingcopyidentity/

ArcanistWorkingCopyIdentity.php

3 lines

Diff 23297

View Options

src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

Pass the file contents instead of the file path to `phutil_json_decode`.ClosedPublicActions