Page MenuHomePhabricator

Don't validate Conduit hosts
ClosedPublic

Authored by epriestley on Jun 24 2014, 12:12 AM.
Tags
None
Referenced Files
F15302906: D9703.id23295.diff
Wed, Mar 5, 11:44 PM
Unknown Object (File)
Fri, Feb 28, 2:32 AM
Unknown Object (File)
Sun, Feb 9, 1:52 PM
Unknown Object (File)
Jan 31 2025, 7:45 PM
Unknown Object (File)
Jan 29 2025, 12:10 PM
Unknown Object (File)
Jan 27 2025, 6:37 AM
Unknown Object (File)
Jan 27 2025, 2:29 AM
Unknown Object (File)
Jan 25 2025, 3:49 PM
Subscribers

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rP85e9f8374a35: Don't validate Conduit hosts
Summary

(See rPd1d3bf4e / rPf371c7b3.) Just get rid of this logic, I don't think there's any value to it.

IIRC, this was added a long time ago to deal with some issues that users had configuring things, but I think modern Phabricator covers all this stuff and I haven't seen any confusion from users for a year or more.

(Generally, I want to generally make Conduit easier to use, and this makes it more difficult.)

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
nohost
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1352
Build 1352: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't validate Conduit hosts.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
This revision is now accepted and ready to land.Jun 24 2014, 12:32 AM
epriestley updated this revision to Diff 23296.

Closed by commit rP85e9f8374a35 (authored by @epriestley).