Ref T5373. This seems to work pretty much correctly.
Also stop popping bubbles and just use the log, since users find the bubbles confusing/not useful and they're not great for developers either.
Future diffs will expose more user-facing stuff.
Details
Details
- Reviewers
joshuaspence - Maniphest Tasks
- T5373: Debugging the `AphlictClient` and `AphlictMaster` is difficult
- Commits
- Restricted Diffusion Commit
rP80f26e96ea40: Install an uncaught exception handler in Aphlict
Added throw to AphlictClient.as, got a log in the parent window.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- aphlict1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1344 Build 1344: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Ahhhh nevermind... I thought I had notification.debug enabled, but it turns out my config file was invalid JSON:
"notification.debug": true }
| support/aphlict/client/src/Aphlict.as | ||
|---|---|---|
| 37 ↗ | (On Diff #23276) | Is this necessary? |
| support/aphlict/client/src/Aphlict.as | ||
|---|---|---|
| 37 ↗ | (On Diff #23276) | It seems that Flash lets us get away with it, but it's more correct to use Object since we sometimes pass strings, not errors. |