Paths

Table of Contentst

Differential D9676

Remove unused JavaScript variables.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 1:11 AM.

Tags

None

Referenced Files

	F13818261: D9676.diff
	Fri, Sep 20, 6:26 AM

	Unknown Object (File)
	Wed, Sep 18, 7:01 PM

	Unknown Object (File)
	Tue, Sep 17, 8:11 PM

	Unknown Object (File)
	Thu, Sep 5, 3:05 PM

	Unknown Object (File)
	Tue, Sep 3, 9:05 AM

	Unknown Object (File)
	Tue, Sep 3, 6:18 AM

	Unknown Object (File)
	Sun, Sep 1, 1:14 PM

	Unknown Object (File)
	Sat, Aug 31, 9:24 PM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPa0d63322b190: Remove unused JavaScript variables.

Summary

There are a bunch of unused variables in JavaScript files. These were identified with JSHint.

Test Plan

It's pretty hard to test this thoroughly... on inspection, it seems that everything should be okay (unless we are doing weird things with the JavaScript).

Diff Detail

Repository

Branch

js-rm_unused_var

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js:731	W003	JSHintW003
Warning	webroot/rsrc/js/application/phortune/behavior-test-payment-form.js:11	W003	JSHintW003

Unit

No Test Coverage

Build Status

Buildable 1314
Build 1314: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23223.Jun 23 2014, 1:11 AM

joshuaspence retitled this revision from to Remove unused JavaScript variables..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 1:11 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1313: Diff 23223.Jun 23 2014, 1:12 AM

I missed a few...

Harbormaster completed remote builds in B1314: Diff 23224.Jun 23 2014, 1:20 AM

I sort of like the explicit parameters in callbacks, but I like getting rid of the unused variables more and don't care enough about them to make jshint raise the two issues separately. I can't think of any logical/behavioral errors that we could detect or prevent by retaining them, either.

This revision is now accepted and ready to land.Jun 23 2014, 4:10 PM

Closed by commit rPa0d63322b190 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

1122 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-listen.js

2 lines

config/

behavior-reorder-fields.js

2 lines

conpherence/

behavior-menu.js

2 lines

behavior-pontificate.js

3 lines

dashboard/

behavior-dashboard-move-panels.js

2 lines

behavior-dashboard-query-panel-select.js

2 lines

behavior-dashboard-tab-panel.js

2 lines

differential/

ChangesetViewManager.js

2 lines

behavior-add-reviewers-and-ccs.js

2 lines

behavior-comment-jump.js

2 lines

behavior-keyboard-nav.js

6 lines

behavior-show-field-details.js

2 lines

diffusion/

DiffusionLocateFileSource.js

1 line

behavior-audit-preview.js

1 line

harbormaster/

behavior-reorder-steps.js

4 lines

herald/

HeraldRuleEditor.js

5 lines

maniphest/

behavior-batch-editor.js

4 lines

behavior-batch-selector.js

2 lines

behavior-list-edit.js

2 lines

behavior-transaction-controls.js

2 lines

behavior-transaction-expand.js

2 lines

owners/

OwnersPathEditor.js

2 lines

passphrase/

phame-credential-control.js

2 lines

phame/

phame-post-preview.js

7 lines

pholio/

behavior-pholio-mock-edit.js

6 lines

behavior-pholio-mock-view.js

3 lines

phortune/

behavior-test-payment-form.js

2 lines

ponder/

behavior-votebox.js

2 lines

projects/

behavior-boards-filter.js

2 lines

behavior-project-boards.js

2 lines

releeph/

releeph-preview-branch.js

2 lines

releeph-request-state-change.js

4 lines

repository/

repository-crossreference.js

2 lines

search/

behavior-reorder-queries.js

4 lines

slowvote/

behavior-slowvote-embed.js

2 lines

transactions/

behavior-transaction-list.js

6 lines

uiexample/

ReactorButtonExample.js

2 lines

ReactorCheckboxExample.js

2 lines

ReactorFocusExample.js

2 lines

ReactorInputExample.js

2 lines

ReactorMouseoverExample.js

2 lines

ReactorRadioExample.js

2 lines

ReactorSelectExample.js

2 lines

ReactorSendClassExample.js

2 lines

ReactorSendPropertiesExample.js

2 lines

busy-example.js

2 lines

gesture-example.js

2 lines

notification-example.js

2 lines

core/

DraggableList.js

1 line

MultirowRowManager.js

2 lines

behavior-active-nav.js

2 lines

behavior-crop.js

14 lines

behavior-dark-console.js

2 lines

behavior-drag-and-drop-textarea.js

4 lines

behavior-fancy-datepicker.js

3 lines

behavior-file-tree.js

4 lines

behavior-form.js

4 lines

behavior-gesture.js

4 lines

behavior-global-drag-and-drop.js

8 lines

behavior-hovercard.js

4 lines

behavior-keyboard-pager.js

4 lines

behavior-lightbox-attachments.js

2 lines

behavior-more.js

2 lines

behavior-object-selector.js

2 lines

behavior-phabricator-nav.js

8 lines

behavior-reorder-applications.js

2 lines

behavior-reveal-content.js

2 lines

behavior-search-typeahead.js

2 lines

behavior-select-on-click.js

2 lines

behavior-tooltip.js

4 lines

Diff 23224

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...

webroot/rsrc/js/application/config/behavior-reorder-fields.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-pontificate.js

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js

Loading...

webroot/rsrc/js/application/differential/ChangesetViewManager.js

Loading...

webroot/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js

Loading...

webroot/rsrc/js/application/differential/behavior-comment-jump.js

Loading...

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Loading...

webroot/rsrc/js/application/differential/behavior-show-field-details.js

Loading...

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js

Loading...

webroot/rsrc/js/application/diffusion/behavior-audit-preview.js

Loading...

webroot/rsrc/js/application/harbormaster/behavior-reorder-steps.js

Loading...

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-batch-editor.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-batch-selector.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-list-edit.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-transaction-controls.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-transaction-expand.js

Loading...

webroot/rsrc/js/application/owners/OwnersPathEditor.js

Loading...

webroot/rsrc/js/application/passphrase/phame-credential-control.js

Loading...

webroot/rsrc/js/application/phame/phame-post-preview.js

Loading...

webroot/rsrc/js/application/pholio/behavior-pholio-mock-edit.js

Loading...

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...

webroot/rsrc/js/application/phortune/behavior-test-payment-form.js

Loading...

webroot/rsrc/js/application/ponder/behavior-votebox.js

Loading...

webroot/rsrc/js/application/projects/behavior-boards-filter.js

Loading...

webroot/rsrc/js/application/projects/behavior-project-boards.js

Loading...

webroot/rsrc/js/application/releeph/releeph-preview-branch.js

Loading...

webroot/rsrc/js/application/releeph/releeph-request-state-change.js

Loading...

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...

webroot/rsrc/js/application/search/behavior-reorder-queries.js

Loading...

webroot/rsrc/js/application/slowvote/behavior-slowvote-embed.js

Loading...

webroot/rsrc/js/application/transactions/behavior-transaction-list.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorButtonExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorCheckboxExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorFocusExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorInputExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorMouseoverExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorRadioExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorSelectExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorSendClassExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js

Loading...

webroot/rsrc/js/application/uiexample/busy-example.js

Loading...

webroot/rsrc/js/application/uiexample/gesture-example.js

Loading...

webroot/rsrc/js/application/uiexample/notification-example.js

Loading...

webroot/rsrc/js/core/DraggableList.js

Loading...

webroot/rsrc/js/core/MultirowRowManager.js

Loading...

webroot/rsrc/js/core/behavior-active-nav.js

Loading...

webroot/rsrc/js/core/behavior-crop.js

Loading...

webroot/rsrc/js/core/behavior-dark-console.js

Loading...

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

Loading...

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...

webroot/rsrc/js/core/behavior-file-tree.js

Loading...

webroot/rsrc/js/core/behavior-form.js

Loading...

webroot/rsrc/js/core/behavior-gesture.js

Loading...

webroot/rsrc/js/core/behavior-global-drag-and-drop.js

Loading...

webroot/rsrc/js/core/behavior-hovercard.js

Loading...

webroot/rsrc/js/core/behavior-keyboard-pager.js

Loading...

webroot/rsrc/js/core/behavior-lightbox-attachments.js

Loading...

webroot/rsrc/js/core/behavior-more.js

Loading...

webroot/rsrc/js/core/behavior-object-selector.js

Loading...

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...

webroot/rsrc/js/core/behavior-reorder-applications.js

Loading...

webroot/rsrc/js/core/behavior-reveal-content.js

Loading...

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...

webroot/rsrc/js/core/behavior-select-on-click.js

Loading...

webroot/rsrc/js/core/behavior-tooltip.js

Loading...