Page MenuHomePhabricator

Remove ajaxey comment magic in Pholio, and also some bugs
ClosedPublic

Authored by epriestley on Jun 21 2014, 6:03 PM.
Tags
None
Referenced Files
F14015473: D9649.id23161.diff
Sun, Nov 3, 7:20 PM
F14015472: D9649.id23158.diff
Sun, Nov 3, 7:20 PM
F13997511: D9649.diff
Thu, Oct 24, 4:52 AM
F13991475: D9649.id.diff
Tue, Oct 22, 11:06 AM
F13974324: D9649.id23158.diff
Fri, Oct 18, 5:08 AM
Unknown Object (File)
Sat, Oct 12, 7:48 AM
Unknown Object (File)
Oct 10 2024, 1:48 PM
Unknown Object (File)
Oct 10 2024, 10:14 AM
Subscribers

Details

Summary

Fixes T5424.

  • One concrete issue: drafts were not being cleared properly because __draft__ was not set on submission. This (mostly) fixes phantom drafts.
  • This ajax comment magic feels weird and floaty and generally has problems. For example, if you add subscribers or inlines, all the stuff on the page which represents those won't update automatically. Instead, just reload. Maybe we'll ajax this stuff some day, but it feels like a net negative for now.
  • Also remove it from other applications where it's currently used.
  • Fix an issue with inline previews.
Test Plan

Made some comments on a mock, everything worked normally like I expected it to.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove ajaxey comment magic in Pholio, and also some bugs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2014, 7:17 PM
epriestley updated this revision to Diff 23161.

Closed by commit rP9f2efd0fa048 (authored by @epriestley).