Fixes T5386, adds a base set of email preferences to Pholio
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5386: Pholio notifications are not configurable in /settings/panel/emailpreferences/
- Commits
- Restricted Diffusion Commit
rPc9a195369f25: Add email preferences to Pholio
Turned on, tested and got email, turned off, tested and saw notifications.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
This seems reasonably "Easy", I can do more in the future - they are good baby watching tasks.
Comment Actions
The "revision" stuff has some issues that we should probably talk through separately, let's put it in a different diff and I'll gab there?
| src/applications/pholio/storage/PholioTransaction.php | ||
|---|---|---|
| 85 | This should include PhabricatorTransactions::TYPE_COMMENT. There are some additional shared types (TYPE_EDGE, TYPE_SUBSCRIBERS) but it's probably fine to ignore them so they end up in "Other" for now. Generally, this is something that could probably do with unification across applications. That would also suggest unified tag types (e.g., a single "comment" type instead of a "pholio comment" type). | |
| src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php | ||
| 62 | These checks should probably be isClassInstalledForViewer() now, but that's an existing issue / not a big deal either way. | |
| 271 | Should be "other mock activity". | |
Comment Actions
Two minor inlines.
| src/applications/pholio/storage/PholioTransaction.php | ||
|---|---|---|
| 66 | (This is already handled by parent::getIcon().) | |
| 86 | Oh, sorry -- this is actually PhabricatorTransactionType::TYPE_COMMENT (i.e., a single type used for all comments in every application). | |
| src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php | ||
| 198–199 | These need a $user parameter. | |