Page MenuHomePhabricator

Fix invalid submit_uri when creating dashboard panels
ClosedPublic

Authored by tobyhughes on Jun 19 2014, 10:29 AM.
Tags
None
Referenced Files
F15481952: D9629.id23103.diff
Wed, Apr 9, 1:12 AM
F15481191: D9629.id23093.diff
Tue, Apr 8, 6:54 PM
F15473237: D9629.id.diff
Sat, Apr 5, 8:37 PM
F15470120: D9629.diff
Fri, Apr 4, 8:08 PM
F15438668: D9629.id23093.diff
Wed, Mar 26, 2:32 AM
F15403023: D9629.id23103.diff
Tue, Mar 18, 1:41 AM
F15397286: D9629.id.diff
Sun, Mar 16, 7:19 PM
F15382799: D9629.diff
Fri, Mar 14, 2:31 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbaf4d451aabb: Fix invalid submit_uri when creating dashboard panels
Summary

When creating dashboard panels, the submit_uri is invalid since the panel has not been saved to the database yet (and therefore doesn't have an ID). This resulted in a 404 when trying to submit the form to /dashboard/panel/edit//

Test Plan

Created a dashboard panel and the panel was created successfully

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tobyhughes retitled this revision from to Fix invalid submit_uri when creating dashboard panels.
tobyhughes updated this object.
tobyhughes edited the test plan for this revision. (Show Details)
tobyhughes added a reviewer: epriestley.
This revision is now accepted and ready to land.Jun 19 2014, 9:19 PM
epriestley updated this revision to Diff 23103.

Closed by commit rPbaf4d451aabb (authored by @tobyhughes, committed by @epriestley).