Fix invalid submit_uri when creating dashboard panels
ClosedPublic
Actions

Authored by tobyhughes on Jun 19 2014, 10:29 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPbaf4d451aabb: Fix invalid submit_uri when creating dashboard panels

Summary

When creating dashboard panels, the submit_uri is invalid since the panel has not been saved to the database yet (and therefore doesn't have an ID). This resulted in a 404 when trying to submit the form to /dashboard/panel/edit//

Test Plan

Created a dashboard panel and the panel was created successfully

Diff Detail

Repository

rP Phabricator

Branch

dashfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1240
Build 1240: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

tobyhughes updated this revision to Diff 23093.Jun 19 2014, 10:29 AM

tobyhughes retitled this revision from to Fix invalid submit_uri when creating dashboard panels.

tobyhughes updated this object.

tobyhughes edited the test plan for this revision. (Show Details)

tobyhughes added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 19 2014, 10:29 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1240: Diff 23093.Jun 19 2014, 10:30 AM

Thanks!

This revision is now accepted and ready to land.Jun 19 2014, 9:19 PM

Closed by commit rPbaf4d451aabb (authored by @tobyhughes, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardPanelEditController.php

7 lines

Diff 23093

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Fix invalid submit_uri when creating dashboard panelsClosedPublicActions