Page MenuHomePhabricator
Differential D9626

Add unit tests for `ArcanistMergeConflictLinter`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 18 2014, 10:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 12:57 PM
Unknown Object (File)
Sat, Jan 18, 7:11 AM
Unknown Object (File)
Sat, Jan 18, 2:56 AM
Unknown Object (File)
Fri, Jan 17, 6:41 AM
Unknown Object (File)
Mon, Jan 6, 4:52 PM
Unknown Object (File)
Dec 31 2024, 6:24 PM
Unknown Object (File)
Dec 31 2024, 5:36 PM
Unknown Object (File)
Dec 31 2024, 12:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC212c41fbd085: Add unit tests for `ArcanistMergeConflictLinter`.
Summary

Self explanatory. Also fixed the character offset to start at 1 instead of 0 (because the other linters seem to do this).

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
mergeconflict
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1236
Build 1236: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23089.Jun 18 2014, 10:28 PM
joshuaspence retitled this revision from to Add unit tests for `ArcanistMergeConflictLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2014, 10:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1236: Diff 23089.Jun 18 2014, 10:29 PM
epriestley accepted this revision.Jun 19 2014, 9:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 19 2014, 9:20 PM
joshuaspence closed this revision.Jun 19 2014, 9:59 PM
joshuaspence updated this revision to Diff 23105.

Closed by commit rARC212c41fbd085 (authored by @joshuaspence).

Revision Contents
Changeset List

Diff 23089

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistMergeConflictLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/mergeconflict/mergeconflict.lint-test

Loading...
Phabricator · Built by Phacility