Various tidying up of linting code.
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Commits
- rARC67b6bed92ec2: Tidying up of linter code.
arc lint and arc unit still pass.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- linter-tidy
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1235 Build 1235: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
The double-newline-between-methods is quasi-intentional, but I'll write a lint rule for it if we want to formalize it. I could also just stop doing it, it's definitely a little weird. Not sure if you have feelings one way or the other.
| src/lint/linter/ArcanistSpellingLinter.php | ||
|---|---|---|
| 145–153 | These should probably use the phutil_utf8_...() flavors, although I don't remember if we have phutil_utf8_ucwords(). | |
| src/lint/linter/__tests__/ArcanistLinterTestCase.php | ||
| 41–45 | This is probably wrong (or will soon be wrong) now, per discussion. | |
Comment Actions
Oh, based on what I had seen I figured the convention was for a single blank line between methods but a double blank line before some kind of header. I'm not fussed either way to be honest.