Paths

Table of Contentst

Differential D9597

Ignore colors and formatting when determining string length.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 7:40 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU68f970cae19f: Ignore colors and formatting when determining string length.

Summary

When calculating the length of a string with phutil_utf8_console_strlen, escape codes shouldn't contribute any width to the string.

This change allows for the widths of a PhutilConsoleTable table to be determined correctly when using rows containing formatting and/or colors.

Test Plan

Before

After

Diff Detail

Repository

rPHU libphutil

Branch

utf8color

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1175
Build 1175: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22989.Jun 17 2014, 7:40 AM

joshuaspence retitled this revision from to Ignore colors and formatting when determining string length..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 7:40 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1170: Diff 22989.Jun 17 2014, 7:41 AM

Consider adding a unit test or two, there should already be a test case.

Does /s do anything in this case? There's no . in the regexp. (For that matter, I don't see a way for U to ever affect behavior.)

This revision is now accepted and ready to land.Jun 17 2014, 11:20 AM

Remove unnecessary sU from regex.
Add unit tests.

Harbormaster completed remote builds in B1175: Diff 23001.Jun 17 2014, 3:59 PM

Closed by commit rPHU68f970cae19f (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

utils/

__tests__/

PhutilUTF8TestCase.php

4 lines

utf8.php

3 lines

Diff 23001

View Options

src/utils/tests/PhutilUTF8TestCase.php

View Options

Ignore colors and formatting when determining string length.ClosedPublicActions