Page MenuHomePhabricator

Fix some off-by-one issues when drag-and-dropping dashboard panels
ClosedPublic

Authored by epriestley on Jun 16 2014, 3:28 PM.
Tags
None
Referenced Files
F18045347: D9573.diff
Sun, Aug 3, 8:51 AM
F18044113: D9573.id22940.diff
Sun, Aug 3, 6:49 AM
F17973297: D9573.id.diff
Fri, Aug 1, 3:59 PM
F17948395: D9573.diff
Thu, Jul 31, 8:59 PM
Unknown Object (File)
May 21 2025, 8:12 PM
Unknown Object (File)
May 8 2025, 7:32 AM
Unknown Object (File)
May 6 2025, 6:43 PM
Unknown Object (File)
Mar 30 2025, 2:37 PM
Subscribers

Details

Summary

Fixes T5321. There were a couple of off-by-one issues here which could result in inserts into the wrong position.

Test Plan
  • Dragged panels to the top, bottom, and first position of columns.
  • Dragged panels from one column to another.
  • Reloaded the page after drags, things stayed where I put them.

Diff Detail

Repository
rP Phabricator
Branch
dash2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1141
Build 1141: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix some off-by-one issues when drag-and-dropping dashboard panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 3:41 PM
epriestley updated this revision to Diff 22942.

Closed by commit rP5f52f1f82cac (authored by @epriestley).