Made some additional methods final.
ClosedPublic
Actions

Authored by joshuaspence on Jun 16 2014, 7:24 AM.

Tags

None

Referenced Files

	F15197264: D9569.id22932.diff
	Sat, Feb 22, 10:22 PM

	F15196177: D9569.diff
	Sat, Feb 22, 4:25 PM

	Unknown Object (File)
	Sun, Feb 9, 1:37 PM

	Unknown Object (File)
	Sun, Feb 9, 1:37 PM

	Unknown Object (File)
	Sun, Feb 9, 1:37 PM

	Unknown Object (File)
	Sun, Feb 9, 1:37 PM

	Unknown Object (File)
	Sat, Feb 1, 2:59 AM

	Unknown Object (File)
	Mon, Jan 27, 3:06 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC497229acd83a: Made some additional methods final.

Summary

Just some minor tidying up. I don't think that these methods should ever be overridden in subclasses.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22932.Jun 16 2014, 7:24 AM

joshuaspence retitled this revision from to Made some additional methods final..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 7:24 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1137: Diff 22932.Jun 16 2014, 7:25 AM

epriestley accepted this revision.Jun 16 2014, 12:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 12:53 PM

Closed by commit rARC497229acd83a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

10 lines

ArcanistLinter.php

4 lines

Diff 22935

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php