Made some additional methods final.
ClosedPublic
Actions

Authored by joshuaspence on Jun 16 2014, 7:24 AM.

Tags

None

Referenced Files

	F14045089: D9569.diff
	Wed, Nov 13, 12:54 AM

	F14040287: D9569.diff
	Mon, Nov 11, 8:43 AM

	F14037979: D9569.diff
	Sun, Nov 10, 8:37 PM

	F14023954: D9569.diff
	Thu, Nov 7, 4:25 AM

	F13999530: D9569.diff
	Thu, Oct 24, 3:23 PM

	F13979257: D9569.id22935.diff
	Sat, Oct 19, 3:34 AM

	Unknown Object (File)
	Oct 13 2024, 10:07 AM

	Unknown Object (File)
	Oct 1 2024, 10:53 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC497229acd83a: Made some additional methods final.

Summary

Just some minor tidying up. I don't think that these methods should ever be overridden in subclasses.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

final

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1137
Build 1137: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22932.Jun 16 2014, 7:24 AM

joshuaspence retitled this revision from to Made some additional methods final..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 7:24 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1137: Diff 22932.Jun 16 2014, 7:25 AM

epriestley accepted this revision.Jun 16 2014, 12:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 12:53 PM

Closed by commit rARC497229acd83a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistBaseXHPASTLinter.php

10 lines

ArcanistLinter.php

4 lines

Diff 22932

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php