Page MenuHomePhabricator
Differential D9568

Update `update_compat_info.php` to use PHP_CompatInfo version 3
ClosedPublic
Actions

Authored by joshuaspence on Jun 16 2014, 6:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 2:00 PM
Unknown Object (File)
Fri, Dec 20, 10:20 AM
Unknown Object (File)
Fri, Dec 20, 10:20 AM
Unknown Object (File)
Fri, Dec 20, 10:20 AM
Unknown Object (File)
Fri, Dec 20, 10:17 AM
Unknown Object (File)
Sun, Dec 15, 5:38 AM
Unknown Object (File)
Sat, Dec 14, 3:10 PM
Unknown Object (File)
Mon, Dec 9, 3:33 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5377: Update `PHP_CompatInfo` bindings
Commits
rARC8f8ab969db17: Update `update_compat_info.php` to use PHP_CompatInfo version 3
Summary

Fixes T5377. The current scripts/update_compat_info.php script works for PHP CompatInfo version 2, but doesn't work with the newer version 3.

There are a few breaking changes in version 3 that had to be addressed:

  • PHP 5.3 is required. Whilst Arcanist is generally compatible with PHP 5.2, I don't think that having this dependency presents any real issues because it is purely a development tool that is rarely updated.
  • Composer is used for packaging, which makes including the library slightly more complicated. Basically, I had to install PHP_CompatInfo globally with Composer (composer global require "bartlett/php-compatinfo" and then symlink ~/.composer/vendor into externals/includes.
Test Plan

Compared the resources/php_compat_info.json file. There are a bunch of functions/classes that were in this file but are no longer, but I think that I've covered the most popular extensions.

Diff Detail

Repository
rARC Arcanist
Branch
phpcompatinfo
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1136
Build 1136: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22930.Jun 16 2014, 6:38 AM
joshuaspence retitled this revision from to Update `update_compat_info.php` to use PHP_CompatInfo version 3.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5377: Update `PHP_CompatInfo` bindings.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 6:38 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1135: Diff 22930.Jun 16 2014, 6:39 AM
joshuaspence added inline comments.Jun 16 2014, 6:42 AM
scripts/update_compat_info.php
9

This isn't great and can possibly be done better.

19–44

I basically hand-picked these from https://github.com/llaville/php-compat-info/tree/v3/src/Bartlett/CompatInfo/Reference/Extension.

joshuaspence added inline comments.Jun 16 2014, 6:48 AM
resources/php_compat_info.json
1

It's a lot easier to diff this file if you sort the keys first.

joshuaspence updated this revision to Diff 22931.Jun 16 2014, 7:00 AM
joshuaspence edited edge metadata.
  • Add the FileInfo extension.
Harbormaster completed remote builds in B1136: Diff 22931.Jun 16 2014, 7:01 AM
epriestley accepted this revision.Jun 16 2014, 12:55 PM
epriestley edited edge metadata.

Yeah, it's fine if you need weird stuff to rebuild artifacts like this.

This revision is now accepted and ready to land.Jun 16 2014, 12:55 PM
joshuaspence closed this revision.Jun 16 2014, 2:30 PM
joshuaspence updated this revision to Diff 22936.

Closed by commit rARC8f8ab969db17 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
resources/
12282 lines
scripts/
83 lines
src/
lint/
linter/
6 lines

Diff 22931

View Options

resources/php_compat_info.json

Loading...
View Options

scripts/update_compat_info.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility