Don't explicitly keep track of `_activeListenerCount` in the Aphlict server.
ClosedPublic
Actions

Authored by joshuaspence on Jun 15 2014, 7:08 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP279a0e53717e: Don't explicitly keep track of `_activeListenerCount` in the Aphlict server.

Summary

The _activeListenerCount variable is overkill, we should be able to achieve the same result using Object.keys(this._listeners).length.

Test Plan

Mucked around in a NodeJS shell.

> Object.keys({}).length
0
> Object.keys({foo: 'bar'}).length
1
> Object.keys({1: 'foo', 2: 'bar'}).length
2

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22903.Jun 15 2014, 7:08 PM

joshuaspence retitled this revision from to Don't explicitly keep track of `_activeListenerCount` in the Aphlict server..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 15 2014, 7:08 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1119: Diff 22903.Jun 15 2014, 7:09 PM

epriestley accepted this revision.Jun 15 2014, 7:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 7:13 PM

Closed by commit rP279a0e53717e (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

support/

aphlict/

server/

lib/

AphlictListenerList.js

5 lines

Diff 22908

View Options

support/aphlict/server/lib/AphlictListenerList.js

Don't explicitly keep track of `_activeListenerCount` in the Aphlict server.ClosedPublicActions