Page MenuHomePhabricator

Rebuild libphutil library map to remove `sprintf_escape` function
ClosedPublic

Authored by epriestley on Jun 15 2014, 7:14 PM.
Tags
None
Referenced Files
F14037098: D9556.id22905.diff
Sun, Nov 10, 1:51 PM
F14037028: D9556.id22909.diff
Sun, Nov 10, 1:30 PM
F14012792: D9556.id.diff
Fri, Nov 1, 6:53 PM
F14008249: D9556.diff
Tue, Oct 29, 6:31 PM
F13977899: D9556.diff
Fri, Oct 18, 8:33 PM
F13966039: D9556.diff
Wed, Oct 16, 5:47 AM
Unknown Object (File)
Sep 20 2024, 12:41 PM
Unknown Object (File)
Sep 12 2024, 6:05 AM
Subscribers

Details

Summary

Minor, fix out-of-date build after D9533.

Test Plan

arc liberate

Diff Detail

Repository
rPHU libphutil
Branch
map
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1121
Build 1121: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rebuild libphutil library map to remove `sprintf_escape` function.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
joshuaspence edited edge metadata.

Whoops, sorry. I didn't notice this because src/__phutil_library_map__.php was shown as collapsed.

This revision is now accepted and ready to land.Jun 15 2014, 7:15 PM

We could detect this sort of thing by running PhutilInfrastructureTestCase. I almost wonder if we should always run this test case?

I think it would take a little effort -- IIRC, we don't look for src/__tests__/ right now -- but I think it's reasonable to make that work and move the src/infrastructure/__tests__/ directory up.

epriestley updated this revision to Diff 22909.

Closed by commit rPHU04712fda4b76 (authored by @epriestley).

I could also imagine writing some kind of arc make which happens during arc land to make sure artifacts like this are generated correctly, but that's a more significant undertaking.

Ideally we probably wouldn't be checking this stuff into the master repository at all, and would just build it for some kind of tarball release kind of thing, but doing that without creating huge barriers for users would require a lot more release/versioning/packaging infrastructure than we currently have.