Differential D9548

Reduce Pholio brokenness for non-image files
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 2:52 PM.

Tags

None

Referenced Files

	F14032988: D9548.diff
	Sat, Nov 9, 4:23 PM

	F14021852: D9548.diff
	Wed, Nov 6, 1:06 PM

	F14002648: D9548.diff
	Fri, Oct 25, 8:55 PM

	F14000790: D9548.id.diff
	Fri, Oct 25, 12:59 AM

	F13965631: D9548.id.diff
	Wed, Oct 16, 3:16 AM

	Unknown Object (File)
	Sep 20 2024, 6:43 AM

	Unknown Object (File)
	Sep 19 2024, 9:15 AM

	Unknown Object (File)
	Sep 18 2024, 1:47 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5359: Improve handling of non-supported image types in Pholio

Commits

Restricted Diffusion Commit
rPdcf3b4d32299: Reduce Pholio brokenness for non-image files

Summary

Ref T5359. When users upload non-image file types (PDFs, text files, whatever), Pholio currently chokes in a few places. Make most of these behaviors more reasonable:

Provide thumbs in the required sizes.
Predict the thumb size of these files correctly.
Disable inline comments.
Make "View Fullsize" and "Download" into buttons. These mostly-work. Download should probaly really download, but CSRF on forms is a bit of a pain right now.

Test Plan

See screenshots.

Diff Detail

Repository

Branch

pho2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/pholio/view/PholioMockImagesView.php:65	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 1111
Build 1111: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22882.Jun 15 2014, 2:52 PM

epriestley retitled this revision from to Reduce Pholio brokenness for non-image files.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5359: Improve handling of non-supported image types in Pholio.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 2:52 PM

Viewing a text file:

Screen_Shot_2014-06-15_at_7.42.49_AM.png (570×1 px, 40 KB)

Embed/pin view:

Screen_Shot_2014-06-15_at_7.50.08_AM.png (309×306 px, 9 KB)

Upload view:

Screen_Shot_2014-06-15_at_7.50.14_AM.png (295×982 px, 14 KB)

Harbormaster completed remote builds in B1110: Diff 22882.Jun 15 2014, 2:54 PM

chad accepted this revision.Jun 15 2014, 2:57 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 2:57 PM

Rebase into light backgrounds.

Screen_Shot_2014-06-15_at_8.00.56_AM.png (811×951 px, 77 KB)

Harbormaster completed remote builds in B1111: Diff 22884.Jun 15 2014, 3:02 PM

Closed by commit rPdcf3b4d32299 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

60 lines

src/

applications/

files/

controller/

PhabricatorFileTransformController.php

11 lines

storage/

PhabricatorFile.php

6 lines

pholio/

view/

PholioMockImagesView.php

13 lines

PholioMockThumbGridView.php

15 lines

infrastructure/

celerity/

11 lines

webroot/

rsrc/

css/

application/

pholio/

pholio-inline-comments.css

1 line

33 lines

image/

icon/

fatcow/

thumbnails/

default.p100.png

default280x210.png

image280x210.png

js/

application/

pholio/

behavior-pholio-mock-view.js

53 lines

Diff 22884

resources/celerity/map.php

Loading...

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/pholio/view/PholioMockImagesView.php

Loading...

src/applications/pholio/view/PholioMockThumbGridView.php

Loading...

src/infrastructure/celerity/api.php

Loading...

webroot/rsrc/css/application/pholio/pholio-inline-comments.css

Loading...

webroot/rsrc/css/application/pholio/pholio.css

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/default.p100.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/default280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/image.p100.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/image280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/pdf.p100.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/pdf280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/zip.p100.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/zip280x210.png

Loading...

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...