Page MenuHomePhabricator
Differential D9544

Use comment icon for Pholio Inline Comments
ClosedPublic
Actions

Authored by chad on Jun 15 2014, 3:57 AM.
Tags
None
Referenced Files
F14339869: D9544.diff
Wed, Dec 18, 6:54 PM
Unknown Object (File)
Tue, Dec 3, 5:12 PM
Unknown Object (File)
Thu, Nov 21, 12:53 AM
Unknown Object (File)
Nov 15 2024, 6:13 PM
Unknown Object (File)
Nov 12 2024, 2:49 PM
Unknown Object (File)
Nov 7 2024, 9:39 PM
Unknown Object (File)
Nov 5 2024, 12:49 AM
Unknown Object (File)
Oct 25 2024, 10:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP2bbafcc924ec: Use comment icon for Pholio Inline Comments
Summary

Uses FontAwesome CSS icons

Test Plan

Check draft and normal states. Click.

undefined (295×471 px, 187 KB)

Diff Detail

Repository
rP Phabricator
Branch
pholio-icons
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1103
Build 1103: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22870.Jun 15 2014, 3:57 AM
chad retitled this revision from to Use comment icon for Pholio Inline Comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 15 2014, 3:57 AM
chad edited the test plan for this revision. (Show Details)Jun 15 2014, 3:57 AM
Harbormaster completed remote builds in B1103: Diff 22870.Jun 15 2014, 3:58 AM
epriestley accepted this revision.Jun 15 2014, 3:59 AM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/application/pholio/pholio.css
148

(Why is only this one right-aligned?)

This revision is now accepted and ready to land.Jun 15 2014, 3:59 AM
chad added inline comments.Jun 15 2014, 4:00 AM
webroot/rsrc/css/application/pholio/pholio.css
148

cmd-z failed me

chad closed this revision.Jun 15 2014, 4:01 AM
chad updated this revision to Diff 22871.

Closed by commit rP2bbafcc924ec (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
38 lines
webroot/
rsrc/
css/
application/
pholio/
17 lines
js/
application/
pholio/
4 lines

Diff 22870

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility