Page MenuHomePhabricator
Differential D9518

make "Land to..." button call diffusion.looksoon
ClosedPublic
Actions

Authored by avivey on Jun 13 2014, 6:38 PM.
Tags
None
Referenced Files
F15299184: D9518.diff
Wed, Mar 5, 2:25 PM
Unknown Object (File)
Mon, Feb 10, 1:31 AM
Unknown Object (File)
Sat, Feb 8, 9:15 AM
Unknown Object (File)
Feb 2 2025, 11:41 PM
Unknown Object (File)
Feb 1 2025, 9:37 PM
Unknown Object (File)
Jan 31 2025, 1:21 AM
Unknown Object (File)
Jan 27 2025, 2:29 PM
Unknown Object (File)
Jan 21 2025, 11:33 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP78c2d5858699: make "Land to..." button call diffusion.looksoon
Summary

add looksoon call after every attempt at landing.

This includes failed attempts, to elevate "not a fast-forward" issues, although there are probably smarter things to be done about that.

Test Plan

Land, look at logs.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1065
Build 1065: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 22815.Jun 13 2014, 6:38 PM
avivey retitled this revision from to make "Land to..." button call diffusion.looksoon.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2014, 6:38 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
avivey planned changes to this revision.Jun 13 2014, 6:38 PM
Harbormaster completed remote builds in B1065: Diff 22815.Jun 13 2014, 6:39 PM
avivey requested a review of this revision.Jun 22 2014, 7:28 PM
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey edited edge metadata.
epriestley accepted this revision.Jun 22 2014, 7:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2014, 7:29 PM
epriestley closed this revision.Jun 22 2014, 7:30 PM
epriestley updated this revision to Diff 23208.

Closed by commit rP78c2d5858699 (authored by @avivey, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
9 lines

Diff 22815

View Options

src/applications/differential/controller/DifferentialRevisionLandController.php

Loading...
Phabricator · Built by Phacility