Page MenuHomePhabricator
Differential D9499

Edit dashboard panels in a dialog instead of on a separate page
ClosedPublic
Actions

Authored by epriestley on Jun 12 2014, 10:34 AM.
Tags
None
Referenced Files
F18463188: D9499.id22768.diff
Tue, Sep 2, 12:24 AM
F18463147: D9499.id.diff
Tue, Sep 2, 12:12 AM
F18463142: D9499.id22768.diff
Tue, Sep 2, 12:12 AM
F18462958: D9499.diff
Mon, Sep 1, 11:42 PM
F18462953: D9499.diff
Mon, Sep 1, 11:40 PM
F18432207: D9499.id.diff
Sun, Aug 31, 6:19 AM
F18416414: D9499.diff
Sat, Aug 30, 10:42 AM
F18091227: D9499.id22756.diff
Wed, Aug 6, 8:25 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPc72e2f35f3db: Edit dashboard panels in a dialog instead of on a separate page
Summary

When you "Edit Panel" on a dashboard, pop a dialog instead of redirecting to a different page.

Test Plan

Edited a panel from a dashboard; edited a panel from the panel workflow.

Diff Detail

Repository
rP Phabricator
Branch
dash1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1029
Build 1029: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22756.Jun 12 2014, 10:34 AM
epriestley retitled this revision from to Edit dashboard panels in a dialog instead of on a separate page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2014, 10:34 AM
Harbormaster completed remote builds in B1029: Diff 22756.Jun 12 2014, 10:35 AM
chad accepted this revision.Jun 12 2014, 4:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2014, 4:21 PM
epriestley closed this revision.Jun 12 2014, 8:22 PM
epriestley updated this revision to Diff 22768.

Closed by commit rPc72e2f35f3db (authored by @epriestley).

Revision Contents
Changeset List

Diff 22756

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
Phabricator · Built by Phacility