Page MenuHomePhabricator
Differential D9499

Edit dashboard panels in a dialog instead of on a separate page
ClosedPublic
Actions

Authored by epriestley on Jun 12 2014, 10:34 AM.
Tags
None
Referenced Files
F14040726: D9499.id22756.diff
Mon, Nov 11, 12:40 PM
F14040725: D9499.id22768.diff
Mon, Nov 11, 12:40 PM
F14025982: D9499.id22768.diff
Thu, Nov 7, 9:37 PM
F13998911: D9499.diff
Thu, Oct 24, 11:47 AM
F13972632: D9499.id.diff
Thu, Oct 17, 8:11 PM
F13955578: D9499.id22768.diff
Oct 14 2024, 2:03 AM
Unknown Object (File)
Oct 7 2024, 12:59 PM
Unknown Object (File)
Sep 29 2024, 8:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPc72e2f35f3db: Edit dashboard panels in a dialog instead of on a separate page
Summary

When you "Edit Panel" on a dashboard, pop a dialog instead of redirecting to a different page.

Test Plan

Edited a panel from a dashboard; edited a panel from the panel workflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22756.Jun 12 2014, 10:34 AM
epriestley retitled this revision from to Edit dashboard panels in a dialog instead of on a separate page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 12 2014, 10:34 AM
Harbormaster completed remote builds in B1029: Diff 22756.Jun 12 2014, 10:35 AM
chad accepted this revision.Jun 12 2014, 4:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 12 2014, 4:21 PM
epriestley closed this revision.Jun 12 2014, 8:22 PM
epriestley updated this revision to Diff 22768.

Closed by commit rPc72e2f35f3db (authored by @epriestley).

Revision Contents
Changeset List

Diff 22768

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
Phabricator · Built by Phacility