Page MenuHomePhabricator

Fix `ArcanistLesscLinter::getVersion` function.
ClosedPublic

Authored by joshuaspence on Jun 11 2014, 2:54 PM.
Tags
None
Referenced Files
F14018772: D9475.diff
Tue, Nov 5, 7:23 PM
F13989080: D9475.id22900.diff
Mon, Oct 21, 5:57 PM
F13969854: D9475.id22657.diff
Thu, Oct 17, 4:13 AM
Unknown Object (File)
Sat, Oct 12, 4:52 AM
Unknown Object (File)
Oct 1 2024, 2:19 AM
Unknown Object (File)
Oct 1 2024, 12:07 AM
Unknown Object (File)
Sep 26 2024, 8:37 PM
Unknown Object (File)
Sep 23 2024, 1:17 AM
Subscribers

Details

Summary

This ArcanistLesscLinter::getCacheVersion should have been renamed to getVersion as of D8971, but wasn't updated.

Also fix the regex to properly capture version information.

Test Plan

It's pretty difficult to test this stuff.... I have an idea that I will submit a separate diff for.

Diff Detail

Repository
rARC Arcanist
Branch
lessversion
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 998
Build 998: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix `ArcanistLesscLinter::getVersion` function..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Just bumping this because it is an easy fix and I want to clear some things from my queue.

As an aside, I was thinking that arc linters --verbose should (maybe) show the version number of all installed external linters, rather than just the configured ones.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 6:49 PM