Page MenuHomePhabricator
Differential D9462

Restore test-sensitive whitespace to some test cases
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 11:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:30 PM
Unknown Object (File)
Tue, Jan 21, 8:39 PM
Unknown Object (File)
Tue, Jan 21, 8:39 PM
Unknown Object (File)
Tue, Jan 21, 9:07 AM
Unknown Object (File)
Fri, Jan 17, 9:29 PM
Unknown Object (File)
Fri, Dec 27, 6:41 PM
Unknown Object (File)
Thu, Dec 26, 8:05 PM
Unknown Object (File)
Dec 15 2024, 1:39 PM
View All Files
Subscribers
epriestley

Details

Reviewers
hach-que
joshuaspence
Commits
Restricted Diffusion Commit
rP8dafabbb1d95: Restore test-sensitive whitespace to some test cases
Summary

This trailing whitespace is meaningful for these files. Also, exclude test data from linting.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
contextunit
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 980
Build 980: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22618.Jun 10 2014, 11:30 PM
epriestley retitled this revision from to Restore test-sensitive whitespace to some test cases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 11:30 PM
Harbormaster completed remote builds in B980: Diff 22618.Jun 10 2014, 11:31 PM
joshuaspence accepted this revision.Jun 10 2014, 11:32 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2014, 11:32 PM
epriestley closed this revision.Jun 10 2014, 11:39 PM
epriestley updated this revision to Diff 22619.

Closed by commit rP8dafabbb1d95 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
2 lines
src/
applications/
differential/
parser/
__tests__/
data/
1 line
1 line
1 line

Diff 22618

View Options

.arclint

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context.diff

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context_2.diff

Loading...
View Options

src/applications/differential/parser/__tests__/data/missing_context_3.diff

Loading...
Phabricator · Built by Phacility