Differential D9449

Apply linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Jun 10 2014, 1:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 4, 6:04 AM

	Unknown Object (File)
	Sat, Dec 21, 11:03 AM

	Unknown Object (File)
	Thu, Dec 19, 8:11 PM

	Unknown Object (File)
	Thu, Dec 12, 11:49 AM

	Unknown Object (File)
	Thu, Dec 12, 8:53 AM

	Unknown Object (File)
	Tue, Dec 10, 5:07 PM

	Unknown Object (File)
	Sun, Dec 8, 11:42 AM

	Unknown Object (File)
	Dec 4 2024, 7:24 AM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

rJXbdb2af92d8c4: Apply linter fixes

Summary

Apply various linter fixes.

Test Plan

Eyeballed it.

Diff Detail

Repository

Branch

lintfix

Lint

Lint Errors

Severity	Location	Code	Message
Error	support/diviner/engine/JavelinDivinerEngine.php:3	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:56	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:98	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:99	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:219	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:297	PHL1	Unknown Symbol
Error	support/diviner/engine/JavelinDivinerEngine.php:299	PHL1	Unknown Symbol

Unit

No Test Coverage

Build Status

Buildable 952
Build 952: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22554.Jun 10 2014, 1:01 AM

joshuaspence retitled this revision from to Apply linter fixes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added reviewers: Blessed Reviewers, chad. · View Herald TranscriptJun 10 2014, 1:01 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B952: Diff 22554.Jun 10 2014, 1:02 AM

The Diviner stuff is very old code for the very old Diviner. I think it's OK to leave it for now, since it hasn't had a replacement written and can still technically run with old Diviner.

This revision is now accepted and ready to land.Jun 10 2014, 5:59 PM

Closed by commit rJXbdb2af92d8c4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

2 lines

1 line

example/

php-tictactoe/

2 lines

php-typeahead/

2 lines

pkg/

2 lines

2 lines

typeahead.min.js

2 lines

workflow.min.js

2 lines

scripts/

2 lines

specs/

jasmine/

6 lines

10 lines

src/

core/

__tests__/

event-stop-and-kill.js

4 lines

1 line

docs/

5 lines

concepts/

behaviors.diviner

1 line

1 line

ext/

reactor/

core/

1 line

1 line

1 line

ReactorNodeCalmer.js

1 line

dom/

2 lines

view/

1 line

1 line

ViewRenderer.js

1 line

1 line

lib/

1 line

__tests__/

3 lines

1 line

control/

typeahead/

source/

TypeaheadCompositeSource.js

1 line

TypeaheadOnDemandSource.js

2 lines

TypeaheadPreloadedSource.js

3 lines

TypeaheadStaticSource.js

3 lines

support/

diviner/

engine/

JavelinDivinerEngine.php

2 lines

jsxmin/

jsxmin_main.cpp

4 lines

jsxmin_reduction.cpp

2 lines

2 lines

6 lines

php/

JavelinHelper.php

13 lines

Diff 22554

.gitignore

Loading...

LICENSE

Loading...

example/php-tictactoe/ai.php

Loading...

example/php-typeahead/animals.txt

Loading...

pkg/init.min.js

Loading...

pkg/javelin.min.js

Loading...

pkg/typeahead.min.js

Loading...

pkg/workflow.min.js

Loading...

scripts/build.sh

Loading...

specs/jasmine/jasmine.css

Loading...

specs/jasmine/jasmine.js

Loading...

src/core/tests/event-stop-and-kill.js

Loading...

src/core/tests/install.js

Loading...

src/docs/Base.js

Loading...

src/docs/concepts/behaviors.diviner

Loading...

src/docs/onload.js

Loading...

src/ext/reactor/core/DynVal.js

Loading...

src/ext/reactor/core/Reactor.js

Loading...

src/ext/reactor/core/ReactorNode.js

Loading...

src/ext/reactor/core/ReactorNodeCalmer.js

Loading...

src/ext/reactor/dom/RDOM.js

Loading...

src/ext/view/HTMLView.js

Loading...

src/ext/view/View.js

Loading...

src/ext/view/ViewRenderer.js

Loading...

src/ext/view/ViewVisitor.js

Loading...

src/lib/DOM.js

Loading...

src/lib/tests/URI.js

Loading...

src/lib/tests/behavior.js

Loading...

src/lib/control/typeahead/source/TypeaheadCompositeSource.js

Loading...

src/lib/control/typeahead/source/TypeaheadOnDemandSource.js

Loading...

src/lib/control/typeahead/source/TypeaheadPreloadedSource.js

Loading...

src/lib/control/typeahead/source/TypeaheadStaticSource.js

Loading...

support/diviner/engine/JavelinDivinerEngine.php

Loading...

support/jsxmin/jsxmin_main.cpp

Loading...

support/jsxmin/jsxmin_reduction.cpp

Loading...

support/jsxmin/reduce.hpp

Loading...

support/jsxmin/reduce.cpp

Loading...

support/php/JavelinHelper.php

Loading...