Paths

Table of Contentst

Differential D9437

Exclude some test data from being linted.
ClosedPublic
Actions

Authored by joshuaspence on Jun 9 2014, 7:07 PM.

Tags

None

Referenced Files

	F14151000: D9437.diff
	Wed, Dec 4, 6:51 PM

	Unknown Object (File)
	Wed, Nov 27, 5:57 AM

	Unknown Object (File)
	Tue, Nov 26, 8:17 AM

	Unknown Object (File)
	Tue, Nov 26, 8:17 AM

	Unknown Object (File)
	Tue, Nov 26, 8:17 AM

	Unknown Object (File)
	Tue, Nov 26, 7:58 AM

	Unknown Object (File)
	Tue, Nov 19, 3:47 AM

	Unknown Object (File)
	Mon, Nov 18, 4:22 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU4ffb05ae9c0c: Exclude some test data from being linted.

Summary

Currently, arc lint --apply-patches will patch some files which contain test data, consequently causing unit tests to file. We should either modify the tests so that they can pass linting and unit tests successfully (if possible), or just exclude them from being linted.

Test Plan

Ran arc lint --apply-patches and ensured that these files were not patched.

Diff Detail

Repository

Branch

arclint

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 939
Build 939: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22532.Jun 9 2014, 7:07 PM

joshuaspence retitled this revision from to Exclude some test data from being linted..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 9 2014, 7:07 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

joshuaspence added inline comments.Jun 9 2014, 7:07 PM

src/parser/xhpast/__tests__/data/php-array-dereference.expect
637	I figured it was easy enough to fix this file rather than disable linting.

Harbormaster completed remote builds in B939: Diff 22532.Jun 9 2014, 7:08 PM

epriestley accepted this revision.Jun 9 2014, 7:09 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2014, 7:09 PM

Closed by commit rPHU4ffb05ae9c0c (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

4 lines

src/

parser/

xhpast/

__tests__/

data/

php-array-dereference.expect

2 lines

php-array-dereference.test

1 line

Diff 22532

.arclint

Loading...

src/parser/xhpast/tests/data/php-array-dereference.expect

Loading...

src/parser/xhpast/tests/data/php-array-dereference.test

Loading...