Page MenuHomePhabricator

Allow `Makefile` files to contain tabs.
ClosedPublic

Authored by joshuaspence on Jun 9 2014, 6:47 PM.
Tags
None
Referenced Files
F14720750: D9436.id22531.diff
Fri, Jan 17, 10:11 PM
Unknown Object (File)
Tue, Jan 14, 11:29 AM
Unknown Object (File)
Thu, Jan 2, 3:52 AM
Unknown Object (File)
Dec 18 2024, 11:40 AM
Unknown Object (File)
Dec 18 2024, 11:40 AM
Unknown Object (File)
Dec 15 2024, 4:47 AM
Unknown Object (File)
Dec 15 2024, 4:47 AM
Unknown Object (File)
Dec 15 2024, 4:29 AM
Subscribers

Details

Summary

Add an entry to the .editorconfig file to allow Makefile files to contains tabs over spaces. Without this entry, my editor will automatically convert the tabs to spaces (which make does not like).

Test Plan

Opened ./support/xhpast/Makefile and saved it. Verified that spaces weren't converted to tabs.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 938
Build 938: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Allow `Makefile` files to contain tabs..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 9 2014, 6:48 PM
epriestley updated this revision to Diff 22531.

Closed by commit rPHU08d38506e416 (authored by @joshuaspence, committed by @epriestley).