Paths

Table of Contentst

Differential D9416

remove destroy`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2014, 6:11 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5286: Allow Herald rules to be deleted with `./bin/remove destroy`

Commits

Restricted Diffusion Commit
rP0a534d1d1f9b: Allow herald rules to be deleted with `./bin/remove destroy`.

Summary

Fixes T5286. Allow herald rules to be deleted using the ./bin/remove destroy workflow.

Test Plan

Created a herald rule. Deleted it with ./bin/remove destroy.

Diff Detail

Repository

rP Phabricator

Branch

rm-herald

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 913
Build 913: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22474.Jun 7 2014, 6:11 PM

joshuaspence retitled this revision from to Allow herald rules to be deleted with `./bin/remove destroy`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5286: Allow Herald rules to be deleted with `./bin/remove destroy`.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2014, 6:11 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B913: Diff 22474.Jun 7 2014, 6:12 PM

epriestley accepted this revision.Jun 7 2014, 6:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2014, 6:18 PM

Closed by commit rP0a534d1d1f9b (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

storage/

HeraldRule.php

14 lines

Diff 22474

View Options

src/applications/herald/storage/HeraldRule.php

Allow herald rules to be deleted with `./bin/remove destroy`.ClosedPublicActions