Page MenuHomePhabricator
Differential D9416

Allow herald rules to be deleted with `./bin/remove destroy`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2014, 6:11 PM.
Tags
None
Referenced Files
F15417912: D9416.diff
Thu, Mar 20, 7:24 PM
F15409101: D9416.diff
Wed, Mar 19, 3:18 AM
F15408881: D9416.diff
Wed, Mar 19, 2:05 AM
F15408706: D9416.diff
Wed, Mar 19, 12:53 AM
F15408512: D9416.diff
Tue, Mar 18, 11:40 PM
F15408086: D9416.diff
Tue, Mar 18, 9:16 PM
F15406959: D9416.diff
Tue, Mar 18, 2:58 PM
F15387746: D9416.id.diff
Sat, Mar 15, 2:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5286: Allow Herald rules to be deleted with `./bin/remove destroy`
Commits
Restricted Diffusion Commit
rP0a534d1d1f9b: Allow herald rules to be deleted with `./bin/remove destroy`.
Summary

Fixes T5286. Allow herald rules to be deleted using the ./bin/remove destroy workflow.

Test Plan

Created a herald rule. Deleted it with ./bin/remove destroy.

Diff Detail

Repository
rP Phabricator
Branch
rm-herald
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 913
Build 913: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22474.Jun 7 2014, 6:11 PM
joshuaspence retitled this revision from to Allow herald rules to be deleted with `./bin/remove destroy`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5286: Allow Herald rules to be deleted with `./bin/remove destroy`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2014, 6:11 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B913: Diff 22474.Jun 7 2014, 6:12 PM
epriestley accepted this revision.Jun 7 2014, 6:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 6:18 PM
epriestley closed this revision.Jun 7 2014, 6:19 PM
epriestley updated this revision to Diff 22475.

Closed by commit rP0a534d1d1f9b (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
storage/
14 lines

Diff 22474

View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility