Page MenuHomePhabricator
Differential D9411

Mark some ActionScript methods as `final`.
ClosedPublic
Actions

Authored by joshuaspence on Jun 6 2014, 8:28 PM.
Tags
None
Referenced Files
F14057357: D9411.diff
Sun, Nov 17, 2:24 AM
F14009745: D9411.diff
Wed, Oct 30, 11:48 PM
F13981929: D9411.id22480.diff
Sat, Oct 19, 8:00 PM
F13964744: D9411.diff
Oct 15 2024, 9:43 PM
F13963766: D9411.id.diff
Oct 15 2024, 5:46 PM
Unknown Object (File)
Sep 15 2024, 12:59 PM
Unknown Object (File)
Sep 14 2024, 12:56 PM
Unknown Object (File)
Sep 14 2024, 12:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7f9a6626a0c4: Mark some ActionScript methods as `final`.
Summary

These methods shouldn't be overridden. Marking them as final will enforce this.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Branch
aphlict-final
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 906
Build 906: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22463.Jun 6 2014, 8:28 PM
joshuaspence retitled this revision from to Mark some ActionScript methods as `final`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 6 2014, 8:28 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B906: Diff 22463.Jun 6 2014, 8:30 PM
epriestley accepted this revision.Jun 7 2014, 6:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 6:31 PM
epriestley closed this revision.Jun 7 2014, 6:35 PM
epriestley updated this revision to Diff 22480.

Closed by commit rP7f9a6626a0c4 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
src/
9 lines
2 lines
2 lines
webroot/
rsrc/
swf/

Diff 22463

View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/AphlictClient.as

Loading...
View Options

support/aphlict/client/src/AphlictMaster.as

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility