Page MenuHomePhabricator

Fix undefinded $changesets when submitting inline comments in Differential
ClosedPublic

Authored by epriestley on Jun 4 2014, 8:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:30 AM
Unknown Object (File)
Wed, Dec 4, 1:20 AM
Unknown Object (File)
Nov 10 2024, 10:49 PM
Unknown Object (File)
Nov 10 2024, 10:49 PM
Unknown Object (File)
Nov 10 2024, 3:12 AM
Unknown Object (File)
Nov 6 2024, 5:03 PM
Unknown Object (File)
Nov 6 2024, 4:14 PM
Unknown Object (File)
Nov 6 2024, 2:36 PM

Details

Summary

Fixes T5262. This branch is overzealous, and causes us to fail to load changeses if metamta.differential.unified-comment-context is off. It was on for me locally for testing, which is why I missed this.

Test Plan

No more exception.

Diff Detail

Repository
rP Phabricator
Branch
change
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 849
Build 849: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix undefinded $changesets when submitting inline comments in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2014, 11:11 PM
epriestley updated this revision to Diff 22358.

Closed by commit rPba2ce8a5ca1a (authored by @epriestley).