Page MenuHomePhabricator
Differential D9351

Making the width of the phriction preview match the width of the actual content
ClosedPublic
Actions

Authored by bluehawk on Jun 2 2014, 11:20 PM.
Tags
None
Referenced Files
F14038309: D9351.id22334.diff
Sun, Nov 10, 10:49 PM
F14038307: D9351.id22335.diff
Sun, Nov 10, 10:49 PM
F14038297: D9351.id22269.diff
Sun, Nov 10, 10:44 PM
F14038296: D9351.id22355.diff
Sun, Nov 10, 10:44 PM
F14038294: D9351.id22265.diff
Sun, Nov 10, 10:44 PM
F14037482: D9351.diff
Sun, Nov 10, 4:20 PM
F14026176: D9351.id22335.diff
Thu, Nov 7, 11:56 PM
F14025627: D9351.id22269.diff
Thu, Nov 7, 7:02 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5243: Phriction document preview width is not the same as actual document width
Commits
Restricted Diffusion Commit
rP0a7618f8b812: Making the width of the phriction preview match the width of the actual content
Summary

Making the width of the phriction preview match the width of the actual content

Test Plan

Edit a phriction article and see that the preview is the correct size

Diff Detail

Repository
rP Phabricator
Branch
phriction-preview-width
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 841
Build 841: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

bluehawk updated this revision to Diff 22265.Jun 2 2014, 11:20 PM
bluehawk retitled this revision from to Making the width of the phriction preview match the width of the actual content.
bluehawk updated this object.
bluehawk edited the test plan for this revision. (Show Details)
bluehawk added reviewers: epriestley, chad.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2014, 11:20 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B806: Diff 22265.Jun 2 2014, 11:22 PM
bluehawk added a comment.Jun 2 2014, 11:22 PM

undefined (802×985 px, 211 KB)

undefined (400×971 px, 212 KB)

bluehawk added a task: T5243: Phriction document preview width is not the same as actual document width.Jun 2 2014, 11:23 PM
chad requested changes to this revision.Jun 2 2014, 11:51 PM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/phui/phui-remarkup-preview.css
31 ↗(On Diff #22265)

Should probably be in document-view so if the width is updated its easy to spot.

This revision now requires changes to proceed.Jun 2 2014, 11:51 PM
bluehawk updated this revision to Diff 22269.Jun 3 2014, 12:10 AM
bluehawk edited edge metadata.
  • Moving changes to phui-document.css
Harbormaster completed remote builds in B809: Diff 22269.Jun 3 2014, 12:11 AM
bluehawk planned changes to this revision.Jun 3 2014, 12:13 AM

Shoot, I think i totally misunderstood your comment. Do you mean that it should be in .device-desktop .phui-document-view

bluehawk added a comment.Jun 3 2014, 12:18 AM

Actually I'm not sure. @chad can you clarify what you meant?

chad added a comment.Jun 3 2014, 1:56 AM

This looks correct, @epriestley would have to land it.

chad added inline comments.Jun 3 2014, 2:05 AM
webroot/rsrc/css/phui/phui-document.css
22

Actually, should probably scope this to .device-desktop as well. You can drag your screen small to hit tablet and phone breakpoints for testing.

bluehawk updated this revision to Diff 22334.Jun 4 2014, 4:13 PM
bluehawk edited edge metadata.
  • Adding .device-desktop so it looks good in mobile and small screens
Harbormaster completed remote builds in B841: Diff 22334.Jun 4 2014, 4:15 PM
bluehawk updated this revision to Diff 22335.Jun 4 2014, 4:16 PM
  • Nothing to see here ._.
Harbormaster completed remote builds in B842: Diff 22335.Jun 4 2014, 4:17 PM
epriestley accepted this revision.Jun 4 2014, 10:40 PM
epriestley edited edge metadata.
epriestley closed this revision.Jun 4 2014, 10:41 PM
epriestley updated this revision to Diff 22355.

Closed by commit rP0a7618f8b812 (authored by @bluehawk, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
webroot/
rsrc/
css/
phui/
5 lines

Diff 22334

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
Phabricator · Built by Phacility