Paths

Table of Contentst

Differential D9351

Making the width of the phriction preview match the width of the actual content
ClosedPublic
Actions

Authored by bluehawk on Jun 2 2014, 11:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 4:54 PM

	Unknown Object (File)
	Thu, Dec 12, 8:12 PM

	Unknown Object (File)
	Sat, Nov 30, 9:44 AM

	Unknown Object (File)
	Nov 19 2024, 2:48 AM

	Unknown Object (File)
	Nov 15 2024, 11:46 AM

	Unknown Object (File)
	Nov 10 2024, 10:49 PM

	Unknown Object (File)
	Nov 10 2024, 10:49 PM

	Unknown Object (File)
	Nov 10 2024, 10:44 PM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5243: Phriction document preview width is not the same as actual document width

Commits

Restricted Diffusion Commit
rP0a7618f8b812: Making the width of the phriction preview match the width of the actual content

Summary

Making the width of the phriction preview match the width of the actual content

Test Plan

Edit a phriction article and see that the preview is the correct size

Diff Detail

Repository

Branch

phriction-preview-width

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 806
Build 806: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

bluehawk updated this revision to Diff 22265.Jun 2 2014, 11:20 PM

bluehawk retitled this revision from to Making the width of the phriction preview match the width of the actual content.

bluehawk updated this object.

bluehawk edited the test plan for this revision. (Show Details)

bluehawk added reviewers: epriestley, chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2014, 11:20 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B806: Diff 22265.Jun 2 2014, 11:22 PM

undefined (802×985 px, 211 KB)

undefined (400×971 px, 212 KB)

bluehawk added a task: T5243: Phriction document preview width is not the same as actual document width.Jun 2 2014, 11:23 PM

chad requested changes to this revision.Jun 2 2014, 11:51 PM

chad edited edge metadata.

chad added inline comments.

webroot/rsrc/css/phui/phui-remarkup-preview.css
31	Should probably be in document-view so if the width is updated its easy to spot.

This revision now requires changes to proceed.Jun 2 2014, 11:51 PM

Moving changes to phui-document.css

Harbormaster completed remote builds in B809: Diff 22269.Jun 3 2014, 12:11 AM

Shoot, I think i totally misunderstood your comment. Do you mean that it should be in .device-desktop .phui-document-view

Actually I'm not sure. @chad can you clarify what you meant?

This looks correct, @epriestley would have to land it.

chad added inline comments.Jun 3 2014, 2:05 AM

webroot/rsrc/css/phui/phui-document.css
22 ↗	(On Diff #22269)	Actually, should probably scope this to .device-desktop as well. You can drag your screen small to hit tablet and phone breakpoints for testing.

Adding .device-desktop so it looks good in mobile and small screens

Harbormaster completed remote builds in B841: Diff 22334.Jun 4 2014, 4:15 PM

Nothing to see here ._.

Harbormaster completed remote builds in B842: Diff 22335.Jun 4 2014, 4:17 PM

epriestley accepted this revision.Jun 4 2014, 10:40 PM

epriestley edited edge metadata.

Closed by commit rP0a7618f8b812 (authored by @bluehawk, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

webroot/

rsrc/

css/

phui/

phui-remarkup-preview.css

4 lines

Diff 22265

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-remarkup-preview.css

Loading...