Here is a screencast showing how this works: http://youtu.be/k5wpyZ6u6rM

In D9327#9, @epriestley wrote:

One minor thing -- let's put a layer of indirection on top of console.log so that this doesn't spam the console up by default.

This seems to work well otherwise. Thanks!

I was actually planning on removing the console logging entirely... Or should I leave it there but use something like JX.Aphlict.didReceiveLog instead so that we can turn it on and off from the JavaScript?

Yeah, I generally think we should move to expose more information about notifications in debug mode. They're somewhat hard to configure right now and they're also hard to support over IRC (users will just be like "it dun work" and I don't have too many tools to help).

Hmm... The console logging doesn't seem to work as I expect.

> __DEV__ = true
true

[After a notification is triggered]
Uncaught Error: JX.Notification.invoke("close", ...): invalid event type. Valid event types are: . core.pkg.js:2
JX.$E core.pkg.js:2
proto.invoke core.pkg.js:67
JX.install.statics._hide core.pkg.js:768
JX.install.members.hide core.pkg.js:765

Hm, still no dice.

Looking at the code, maybe the cleaner approach would be to raise these as a normal event (with type log or similar).

The actual flag that should be used is config.debug in the aphlict-listen behavior (which is derived from notification.debug in Phabricator's config). The __DEV__ constant is sort of correlated, but notification.debug is a much better flag to use.

However, it's not readily available at the JX.Aphlict level. If these events are just normal events with type log, it could be handled in onaphlictmessage() in the aphlict-listen behavior (and will be automatically, I think).

Well, it will be handled automatically by being shown as a bubble. That might be annoying, but we could special case it if it is. I don't think it's terrible to start out with logs going to bubbles, for now.

I still can't figure out how to make the logging work :(

In D9327#30, @joshuaspence wrote:

I still can't figure out how to make the logging work :(

Nevermind... it does seem to work. I do still get Uncaught Error: JX.Routable.listen("start", ...): invalid event type. Valid event types are: . in the console, but this must be unrelated.

Enable notification.debug in your config? Works fine for me:

You'll also need phabricator.developer-mode on, possibly, depending on some other configuration.

(If stuff is being minified with jsxmin in production mode (which is complicated and under/un-documented, but maybe you've been ambitious in configuring this) the __DEV__ blocks will be completely removed from the minified version of the Javascript, so changing __DEV__ at runtime won't have an effect. It's unlikely this is the issue, though.)

In D9327#35, @epriestley wrote:

Enable notification.debug in your config? Works fine for me:

You'll also need phabricator.developer-mode on, possibly, depending on some other configuration.

(If stuff is being minified with jsxmin in production mode (which is complicated and under/un-documented, but maybe you've been ambitious in configuring this) the __DEV__ blocks will be completely removed from the minified version of the Javascript, so changing __DEV__ at runtime won't have an effect. It's unlikely this is the issue, though.)

Possibly a stupid question, but am I meant to set __DEV__ = true in the console? Or is there a proper way to do this?

In general: __DEV__ should be set automatically, based on the phabricator.developer-mode setting. You should not need to set it from the console.

Specifically:

• __DEV__ is defined directly, in PhabricatorBarePageView, based on the value of phabricator.developer-mode. If you "View Source", you should see the definition near the top of the page in the headers.
• When Javascript is minified with jsxmin (a complex, purpose-built minifier), __DEV__ is evaluated as 0 and trivially unreachable branches are stripped. This means that if (__DEV__) { ... } blocks are completely removed by the minifier. This is the primary purpose of the __DEV__ flag: it marks blocks for total removal in production JS builds.
• Since building jsxmin is complicated and the benefits (slightly smaller JS wire size) aren't huge (we fall back to a less sophisticated minifier if jsxmin is not available), we don't currently expect installs to build or configure jsxmin. I don't think we even have it running on this server right now. In these cases, __DEV__ is just equivalent to phabricator.developer-mode.

In D9327#37, @epriestley wrote:

In general: __DEV__ should be set automatically, based on the phabricator.developer-mode setting. You should not need to set it from the console.

Yep, that got it. Thanks.