Page MenuHomePhabricator
Differential D9323

Modify the Aphlict client to use `LocalConnection`.
AbandonedPublic
Actions

Authored by joshuaspence on May 28 2014, 11:24 PM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4324: Change notification server so it only alerts appropriate clients
Summary

Ref T4324. This is a WIP.

Test Plan

Please ignore this for now.

Diff Detail

Repository
rP Phabricator
Branch
aphlict
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/aphlict/client/src/Aphlict.as:91SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 748
Build 748: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22122.May 28 2014, 11:24 PM
joshuaspence retitled this revision from to Modify the Aphlict client to use `LocalConnection`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T4324: Change notification server so it only alerts appropriate clients.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 11:24 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B747: Diff 22122.May 28 2014, 11:25 PM
joshuaspence removed reviewers: epriestley, Blessed Reviewers.May 28 2014, 11:35 PM
joshuaspence removed subscribers: epriestley, Korvin.
joshuaspence updated this revision to Diff 22123.May 28 2014, 11:38 PM
  • Add debug stuff.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 11:38 PM
Harbormaster completed remote builds in B748: Diff 22123.May 28 2014, 11:39 PM
joshuaspence updated this revision to Diff 22124.May 28 2014, 11:57 PM
joshuaspence edited edge metadata.
  • More debug
Harbormaster completed remote builds in B749: Diff 22124.May 28 2014, 11:58 PM
joshuaspence updated this revision to Diff 22125.May 28 2014, 11:59 PM
  • Too much debug
Harbormaster completed remote builds in B750: Diff 22125.May 29 2014, 12:00 AM
joshuaspence updated this revision to Diff 22126.May 29 2014, 12:05 AM
  • Don't duplicate subjects
Harbormaster completed remote builds in B751: Diff 22126.May 29 2014, 12:06 AM
joshuaspence updated this revision to Diff 22127.May 29 2014, 12:12 AM

This works now.

Harbormaster completed remote builds in B752: Diff 22127.May 29 2014, 12:13 AM
joshuaspence updated this revision to Diff 22128.May 29 2014, 12:23 AM

Or maybe not... gah.

Harbormaster completed remote builds in B753: Diff 22128.May 29 2014, 12:24 AM
joshuaspence updated this revision to Diff 22129.May 29 2014, 12:30 AM
  • WTF
Harbormaster completed remote builds in B754: Diff 22129.May 29 2014, 12:31 AM
joshuaspence updated this revision to Diff 22130.May 29 2014, 12:32 AM
  • Why are some clients registering twice or something? Hmm
Harbormaster completed remote builds in B755: Diff 22130.May 29 2014, 12:33 AM
joshuaspence updated this revision to Diff 22131.May 29 2014, 12:47 AM
  • More changes
Harbormaster completed remote builds in B756: Diff 22131.May 29 2014, 12:48 AM
joshuaspence updated this revision to Diff 22134.May 29 2014, 1:18 AM
  • Refactor
Harbormaster completed remote builds in B758: Diff 22134.May 29 2014, 1:19 AM
joshuaspence updated this revision to Diff 22135.May 29 2014, 1:25 AM
  • Another iteration
Harbormaster completed remote builds in B759: Diff 22135.May 29 2014, 1:26 AM
joshuaspence updated this revision to Diff 22136.May 29 2014, 1:28 AM
  • Make sure to create the LocalConnection
Harbormaster completed remote builds in B760: Diff 22136.May 29 2014, 1:29 AM
joshuaspence updated this revision to Diff 22137.May 29 2014, 1:32 AM
  • Infinite loop to server the master alive
Harbormaster completed remote builds in B761: Diff 22137.May 29 2014, 1:33 AM
joshuaspence updated this revision to Diff 22138.May 29 2014, 1:46 AM
  • Keepalive
Harbormaster completed remote builds in B762: Diff 22138.May 29 2014, 1:47 AM
joshuaspence updated this revision to Diff 22139.May 29 2014, 2:04 AM
  • Let's try this
Harbormaster completed remote builds in B763: Diff 22139.May 29 2014, 2:05 AM
joshuaspence updated this revision to Diff 22140.May 29 2014, 2:08 AM
  • Try to retain the master
Harbormaster completed remote builds in B764: Diff 22140.May 29 2014, 2:09 AM
joshuaspence updated this revision to Diff 22141.May 29 2014, 2:11 AM
  • Fix some stuff
Harbormaster completed remote builds in B765: Diff 22141.May 29 2014, 2:12 AM
joshuaspence updated this revision to Diff 22142.May 29 2014, 2:13 AM
  • I hate ActionScript
joshuaspence updated this revision to Diff 22143.May 29 2014, 2:13 AM
  • Try again
Harbormaster completed remote builds in B766: Diff 22142.May 29 2014, 2:14 AM
Harbormaster completed remote builds in B767: Diff 22143.
joshuaspence updated this revision to Diff 22144.May 29 2014, 2:15 AM
  • Try again again
chad edited reviewers, added: epriestley; removed: Blessed Reviewers.May 29 2014, 2:15 AM
Harbormaster completed remote builds in B768: Diff 22144.May 29 2014, 2:16 AM
joshuaspence removed a reviewer: epriestley.May 29 2014, 2:19 AM
joshuaspence updated this revision to Diff 22145.May 29 2014, 2:19 AM
joshuaspence added a reviewer: epriestley.
  • Try again
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2014, 2:19 AM
joshuaspence removed a reviewer: Blessed Reviewers.May 29 2014, 2:19 AM
Harbormaster completed remote builds in B769: Diff 22145.May 29 2014, 2:20 AM
joshuaspence updated this revision to Diff 22146.May 29 2014, 2:22 AM
  • Try again
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2014, 2:22 AM
chad added a subscriber: chad.May 29 2014, 2:22 AM

I am stuck! hahaha

Harbormaster completed remote builds in B770: Diff 22146.May 29 2014, 2:23 AM
joshuaspence added a comment.May 29 2014, 2:23 AM
In D9323#81, @chad wrote:

I am stuck! hahaha

Doh... sorry... I really need a better way to get this to the box I am testing on. Let me try removing the repo from the diff.

joshuaspence removed reviewers: Blessed Reviewers, epriestley.May 29 2014, 2:24 AM
joshuaspence removed rP Phabricator as the repository for this revision.
joshuaspence removed a subscriber: chad.
joshuaspence updated this revision to Diff 22147.May 29 2014, 2:25 AM

I hope this doesn't add Chad again.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2014, 2:25 AM
Harbormaster completed remote builds in B771: Diff 22147.May 29 2014, 2:26 AM
joshuaspence abandoned this revision.May 29 2014, 2:29 AM

I can use arc diff --preview.

joshuaspence added a comment.May 29 2014, 8:18 AM

Sorry about the differential spam earlier. I was developing on one machine and testing on another and this was the easiest way to sync the two.

Revision Contents
Changeset List

PathSize
support/
aphlict/
client/
13 lines
src/
80 lines
com/
phabricator/
24 lines
webroot/
rsrc/
swf/

Diff 22123

View Options

support/aphlict/client/build_aphlict_client.sh

Loading...
View Options

support/aphlict/client/src/Aphlict.as

Loading...
View Options

support/aphlict/client/src/com/phabricator/AphlictReceiver.as

Loading...
View Options

webroot/rsrc/swf/aphlict.swf

Loading...
Phabricator · Built by Phacility