Page MenuHomePhabricator

Fix Diffusion blame/highlight for logged-out users
ClosedPublic

Authored by epriestley on May 27 2014, 8:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 6 2026, 10:42 AM
Unknown Object (File)
Mar 2 2026, 11:13 AM
Unknown Object (File)
Feb 27 2026, 5:01 PM
Unknown Object (File)
Feb 15 2026, 6:56 PM
Unknown Object (File)
Feb 4 2026, 12:26 AM
Unknown Object (File)
Jan 10 2026, 2:06 AM
Unknown Object (File)
Dec 25 2025, 5:15 PM
Unknown Object (File)
Dec 11 2025, 5:05 AM
Subscribers

Details

Summary

Fixes T5199. We try to save these options in user preferences, but logged-out users don't have preferences.

Instead, just use GET links for logged-out users.

Test Plan
  • As a logged-out user, toggled blame and highlight on and off.
  • As a logged-in user, toggled blame and highlight on and off.

Diff Detail

Repository
rP Phabricator
Branch
viewerform
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 724
Build 724: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix Diffusion blame/highlight for logged-out users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: vrana, btrahan.
vrana edited edge metadata.
This revision is now accepted and ready to land.May 28 2014, 12:37 AM
epriestley updated this revision to Diff 22100.

Closed by commit rP2aef04a78afb (authored by @epriestley).