Fix issue when editing a project with no secondary hash tags
ClosedPublic
Actions

Authored by epriestley on May 26 2014, 1:36 PM.

Tags

None

Referenced Files

	F14061865: D9300.id22072.diff
	Mon, Nov 18, 8:53 AM

	F14061863: D9300.id22099.diff
	Mon, Nov 18, 8:53 AM

	F13987479: D9300.diff
	Mon, Oct 21, 9:42 AM

	Unknown Object (File)
	Oct 5 2024, 5:02 AM

	Unknown Object (File)
	Sep 30 2024, 2:23 PM

	Unknown Object (File)
	Sep 30 2024, 7:58 AM

	Unknown Object (File)
	Sep 30 2024, 2:12 AM

	Unknown Object (File)
	Sep 30 2024, 1:52 AM

View All Files

Subscribers

epriestley

Tokens

"Haypence" token, awarded by btrahan.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5186: Cannot edit projects

Commits

Restricted Diffusion Commit
rP70ec8052fddc: Fix issue when editing a project with no secondary hash tags

Summary

Fixes T5186. If a project has no secondary tags, we issue a bogus query right now.

Test Plan

Edited a project with no secondary tags.

Diff Detail

Repository

rP Phabricator

Branch

proj1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 713
Build 713: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22072.May 26 2014, 1:36 PM

epriestley retitled this revision from to Fix issue when editing a project with no secondary hash tags.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5186: Cannot edit projects.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 26 2014, 1:36 PM

Harbormaster completed remote builds in B713: Diff 22072.May 26 2014, 1:37 PM

epriestley added a reviewer: chad.May 28 2014, 12:19 AM

chad accepted this revision.May 28 2014, 12:21 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 28 2014, 12:21 AM

Closed by commit rP70ec8052fddc (authored by @epriestley).

ty for fixies

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

11 lines

Diff 22072

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Fix issue when editing a project with no secondary hash tagsClosedPublicActions