Fix issue when editing a project with no secondary hash tags
ClosedPublic
Actions

Authored by epriestley on May 26 2014, 1:36 PM.

Tags

None

Referenced Files

	F18734911: D9300.id.diff
	Tue, Sep 30, 11:05 PM

	F18698703: D9300.diff
	Sat, Sep 27, 11:48 AM

	F18623982: D9300.id22099.diff
	Mon, Sep 15, 6:20 PM

	F18620320: D9300.id22099.diff
	Mon, Sep 15, 4:54 AM

	F18620319: D9300.id22099.diff
	Mon, Sep 15, 4:53 AM

	F18617372: D9300.diff
	Sun, Sep 14, 9:02 PM

	F18603529: D9300.id22072.diff
	Sat, Sep 13, 5:26 PM

	F18596389: D9300.id22072.diff
	Sat, Sep 13, 12:35 AM

View All Files

Subscribers

epriestley

Tokens

"Haypence" token, awarded by btrahan.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5186: Cannot edit projects

Commits

Restricted Diffusion Commit
rP70ec8052fddc: Fix issue when editing a project with no secondary hash tags

Summary

Fixes T5186. If a project has no secondary tags, we issue a bogus query right now.

Test Plan

Edited a project with no secondary tags.

Diff Detail

Repository

rP Phabricator

Branch

proj1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 713
Build 713: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22072.May 26 2014, 1:36 PM

epriestley retitled this revision from to Fix issue when editing a project with no secondary hash tags.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5186: Cannot edit projects.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 26 2014, 1:36 PM

Harbormaster completed remote builds in B713: Diff 22072.May 26 2014, 1:37 PM

epriestley added a reviewer: chad.May 28 2014, 12:19 AM

chad accepted this revision.May 28 2014, 12:21 AM

chad edited edge metadata.

This revision is now accepted and ready to land.May 28 2014, 12:21 AM

Closed by commit rP70ec8052fddc (authored by @epriestley).

ty for fixies

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

11 lines

Diff 22072

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Fix issue when editing a project with no secondary hash tagsClosedPublicActions