Page MenuHomePhabricator
Differential D9289

Introduce DifferentialChangesetQuery and remove loadHunks()
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 4:01 PM.
Tags
None
Referenced Files
F15471904: D9289.diff
Sat, Apr 5, 9:20 AM
F15454115: D9289.id22328.diff
Sat, Mar 29, 4:24 PM
F15450158: D9289.id22054.diff
Fri, Mar 28, 2:18 PM
F15448764: D9289.id.diff
Fri, Mar 28, 6:47 AM
F15446239: D9289.diff
Thu, Mar 27, 5:53 PM
F15419363: D9289.diff
Fri, Mar 21, 5:35 AM
F15402883: D9289.id22054.diff
Tue, Mar 18, 12:50 AM
Unknown Object (File)
Feb 28 2025, 4:43 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rPbb306b58d553: Introduce DifferentialChangesetQuery and remove loadHunks()
Summary

Ref T4045. Ref T5179. This removes all non-Query hunk loads.

Test Plan
  • Viewed revisions.
  • Viewed standalone changesets.
  • Viewed raw old/new files.
  • Viewed vs diffs.
  • Enabled inline comments in mail and sent some transactions with inlines.
  • Called differential.getrawdiff.
  • Grepped for loadHunks().

Diff Detail

Repository
rP Phabricator
Branch
hunk4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 697
Build 697: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22054.May 25 2014, 4:01 PM
epriestley retitled this revision from to Introduce DifferentialChangesetQuery and remove loadHunks().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 4:01 PM
Harbormaster completed remote builds in B697: Diff 22054.May 25 2014, 4:02 PM
btrahan accepted this revision.Jun 3 2014, 10:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:12 PM
epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22328.

Closed by commit rPbb306b58d553 (authored by @epriestley).

Revision Contents
Changeset List

Diff 22054

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/query/DifferentialChangesetQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialDiffQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
Phabricator · Built by Phacility