Page MenuHomePhabricator

Introduce DifferentialChangesetQuery and remove loadHunks()
ClosedPublic

Authored by epriestley on May 25 2014, 4:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 3:13 AM
Unknown Object (File)
Fri, Dec 20, 9:29 AM
Unknown Object (File)
Sun, Dec 15, 12:26 PM
Unknown Object (File)
Thu, Dec 12, 8:46 AM
Unknown Object (File)
Wed, Dec 11, 8:31 AM
Unknown Object (File)
Sun, Dec 8, 8:43 AM
Unknown Object (File)
Sun, Dec 8, 1:08 AM
Unknown Object (File)
Fri, Dec 6, 4:40 PM
Subscribers

Details

Summary

Ref T4045. Ref T5179. This removes all non-Query hunk loads.

Test Plan
  • Viewed revisions.
  • Viewed standalone changesets.
  • Viewed raw old/new files.
  • Viewed vs diffs.
  • Enabled inline comments in mail and sent some transactions with inlines.
  • Called differential.getrawdiff.
  • Grepped for loadHunks().

Diff Detail

Repository
rP Phabricator
Branch
hunk4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 697
Build 697: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Introduce DifferentialChangesetQuery and remove loadHunks().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:12 PM
epriestley updated this revision to Diff 22328.

Closed by commit rPbb306b58d553 (authored by @epriestley).