Page MenuHomePhabricator
Differential D9246

Add an `ArcanistGoLintLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 21 2014, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 9:33 PM
Unknown Object (File)
Tue, Dec 31, 7:37 AM
Unknown Object (File)
Mon, Dec 30, 10:56 PM
Unknown Object (File)
Fri, Dec 20, 11:46 PM
Unknown Object (File)
Tue, Dec 17, 10:10 PM
Unknown Object (File)
Sun, Dec 15, 10:08 AM
Unknown Object (File)
Sun, Dec 15, 7:31 AM
Unknown Object (File)
Sun, Dec 15, 5:14 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC042aa2ee38df: Add an `ArcanistGoLintLinter`.
Summary

Create bindings for golint as an external linter.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21960.May 21 2014, 9:16 PM
joshuaspence retitled this revision from to Add an `ArcanistGoLintLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 9:16 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B639: Diff 21960.May 21 2014, 9:17 PM
joshuaspence updated this revision to Diff 21961.May 21 2014, 9:18 PM
joshuaspence edited edge metadata.

Diff against the right branch.

Harbormaster completed remote builds in B640: Diff 21961.May 21 2014, 9:20 PM
epriestley requested changes to this revision.May 22 2014, 4:11 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/linter/ArcanistGoLintLinter.php
56

This should return false for supportsSeverityConfigurationOrWhateverTheMethodNameIs().

This revision now requires changes to proceed.May 22 2014, 4:11 PM
joshuaspence updated this revision to Diff 22009.May 23 2014, 2:56 PM
joshuaspence edited edge metadata.

Return false for canCustomizeLintSeverities.

Harbormaster completed remote builds in B669: Diff 22009.May 23 2014, 2:58 PM
epriestley accepted this revision.May 23 2014, 2:59 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 23 2014, 2:59 PM
epriestley closed this revision.May 23 2014, 3:00 PM
epriestley updated this revision to Diff 22011.

Closed by commit rARC042aa2ee38df (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
4 lines
lint/
linter/
60 lines
__tests__/
12 lines
golint/
18 lines

Diff 22011

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/ArcanistGoLintLinter.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/golint/1.lint-test

Loading...
Phabricator · Built by Phacility