Don't fatal when viewing a moved document if the target does not exist or isn't visible
ClosedPublic
Actions

Authored by epriestley on May 22 2014, 3:10 PM.

Details

Reviewers

Maniphest Tasks

T5156: Exception when loading moved documents

Commits

Restricted Diffusion Commit
rP890ae77a9a47: Don't fatal when viewing a moved document if the target does not exist or isn't…

Summary

Fixes T5156. If a document has been moved but the new one does not exist or can't be seen by the viewer, render a generic message.

Test Plan

Viewed moved-plus-visible and moved-plus-nonvisible documents.

Diff Detail

Repository

rP Phabricator

Branch

phrictionmove

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 648
Build 648: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21971.May 22 2014, 3:10 PM

epriestley retitled this revision from to Don't fatal when viewing a moved document if the target does not exist or isn't visible.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5156: Exception when loading moved documents.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 22 2014, 3:10 PM

Harbormaster completed remote builds in B648: Diff 21971.May 22 2014, 3:11 PM

btrahan accepted this revision.May 22 2014, 4:42 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/phriction/controller/PhrictionDocumentController.php
150	s/contne/content/

This revision is now accepted and ready to land.May 22 2014, 4:42 PM

Closed by commit rP890ae77a9a47 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

41 lines

Diff 21971

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Don't fatal when viewing a moved document if the target does not exist or isn't visibleClosedPublicActions