Page MenuHomePhabricator
Differential D9254

Don't fatal when viewing a moved document if the target does not exist or isn't visible
ClosedPublic
Actions

Authored by epriestley on May 22 2014, 3:10 PM.
Tags
None
Referenced Files
F15554159: D9254.id21980.diff
Mon, Apr 28, 5:45 AM
F15529651: D9254.id21971.diff
Tue, Apr 22, 9:27 PM
F15523330: D9254.diff
Mon, Apr 21, 12:39 AM
F15520783: D9254.id21980.diff
Sun, Apr 20, 8:23 AM
F15520710: D9254.id.diff
Sun, Apr 20, 7:28 AM
F15518914: D9254.diff
Sat, Apr 19, 6:03 PM
F15513854: D9254.diff
Thu, Apr 17, 10:14 PM
F15432727: D9254.diff
Mar 24 2025, 7:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5156: Exception when loading moved documents
Commits
Restricted Diffusion Commit
rP890ae77a9a47: Don't fatal when viewing a moved document if the target does not exist or isn't…
Summary

Fixes T5156. If a document has been moved but the new one does not exist or can't be seen by the viewer, render a generic message.

Test Plan

Viewed moved-plus-visible and moved-plus-nonvisible documents.

Diff Detail

Repository
rP Phabricator
Branch
phrictionmove
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 648
Build 648: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21971.May 22 2014, 3:10 PM
epriestley retitled this revision from to Don't fatal when viewing a moved document if the target does not exist or isn't visible.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5156: Exception when loading moved documents.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 22 2014, 3:10 PM
Harbormaster completed remote builds in B648: Diff 21971.May 22 2014, 3:11 PM
btrahan accepted this revision.May 22 2014, 4:42 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phriction/controller/PhrictionDocumentController.php
150

s/contne/content/

This revision is now accepted and ready to land.May 22 2014, 4:42 PM
epriestley closed this revision.May 22 2014, 5:39 PM
epriestley updated this revision to Diff 21980.

Closed by commit rP890ae77a9a47 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
41 lines

Diff 21971

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
Phabricator · Built by Phacility