Differential D9243

Expose dashboard policy editing to UI
ClosedPublic
Actions

Authored by lpriestley on May 21 2014, 7:19 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4981: Allow Dashboard view and edit policies to be configured

Commits

Restricted Diffusion Commit
rPfbbb43c4727b: Expose dashboard policy editing to UI

Summary

Fixes T4981, Allow Dashboard view and edit policies to be configured

Test Plan

Create dashboard, edit dashboard, make sure user can edit who can edit and who can see dashboard.

Diff Detail

Repository

rP Phabricator

Branch

editdashboardpolicy

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 636
Build 636: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 21951.May 21 2014, 7:19 PM

lpriestley retitled this revision from to Expose dashboard policy editing to UI.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4981: Allow Dashboard view and edit policies to be configured.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 7:19 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B636: Diff 21951.May 21 2014, 7:20 PM

epriestley accepted this revision.May 21 2014, 7:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 21 2014, 7:23 PM

Closed by commit rPfbbb43c4727b (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardEditController.php

30 lines

editor/

PhabricatorDashboardTransactionEditor.php

2 lines

Diff 21951

View Options

src/applications/dashboard/controller/PhabricatorDashboardEditController.php