Page MenuHomePhabricator
Differential D9235

Allow a limit to be set on the number of results in a query panel
ClosedPublic
Actions

Authored by hach-que on May 21 2014, 7:10 AM.
Tags
None
Referenced Files
F13163184: D9235.diff
Mon, May 6, 6:16 PM
Unknown Object (File)
Thu, May 2, 2:23 AM
Unknown Object (File)
Sat, Apr 27, 12:00 PM
Unknown Object (File)
Wed, Apr 24, 10:48 PM
Unknown Object (File)
Sat, Apr 20, 6:55 PM
Unknown Object (File)
Thu, Apr 11, 10:02 AM
Unknown Object (File)
Mar 31 2024, 11:19 PM
Unknown Object (File)
Feb 7 2024, 9:44 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4980: Move Dashboards to beta
Commits
Restricted Diffusion Commit
rP49c15a6d951c: Allow a limit to be set on the number of results in a query panel
Summary

This allows a maximum number of items to be set in a query panel. Mostly useful when you have a query panel on the feed search and you don't want 4 billion results cluttering your dashboard.

Test Plan

Created a query panel with a maximum and it worked. Left it blank and got the default results.

Diff Detail

Repository
rP Phabricator
Branch
dashboard-query-limit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 624
Build 624: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 21930.May 21 2014, 7:10 AM
hach-que retitled this revision from to Allow a limit to be set on the number of results in a query panel.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T4980: Move Dashboards to beta.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 7:10 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B624: Diff 21930.May 21 2014, 7:12 AM
epriestley accepted this revision.May 21 2014, 5:09 PM
epriestley edited edge metadata.

We should probably default this to, like, 10, too.

This revision is now accepted and ready to land.May 21 2014, 5:09 PM
epriestley closed this revision.May 21 2014, 5:09 PM
epriestley updated this revision to Diff 21934.
epriestley added a subscriber: Unknown Object (User).

Closed by commit rP49c15a6d951c (authored by @jamesr, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
dashboard/
paneltype/
13 lines

Diff 21930

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeQuery.php

Loading...
Phabricator · Built by Phacility