Page MenuHomePhabricator
Differential D9227

Diffusion browser: Update editor link when clicking on a line
ClosedPublic
Actions

Authored by avivey on May 20 2014, 11:00 PM.
Tags
None
Referenced Files
F13818403: D9227.diff
Fri, Sep 20, 7:34 AM
F13815587: D9227.id21913.diff
Thu, Sep 19, 10:40 AM
Unknown Object (File)
Sat, Sep 14, 8:59 AM
Unknown Object (File)
Wed, Sep 4, 11:19 PM
Unknown Object (File)
Wed, Aug 28, 8:09 PM
Unknown Object (File)
Aug 10 2024, 11:37 AM
Unknown Object (File)
Aug 8 2024, 12:50 AM
Unknown Object (File)
Aug 4 2024, 7:42 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP9bba4cda2fe5: Diffusion browser: Update editor link when clicking on a line
Summary

Highlighing and URL are fixed on click - now the edit button too.

Test Plan

click on lines with and without value in "Editr Link" (And without %l in it).

Diff Detail

Repository
rP Phabricator
Branch
fixeditlink
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 612
Build 612: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 21913.May 20 2014, 11:00 PM
avivey retitled this revision from to Diffusion browser: Update editor link when clicking on a line.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 20 2014, 11:00 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B612: Diff 21913.May 20 2014, 11:01 PM
avivey added a comment.EditedMay 20 2014, 11:02 PM

This actually doesn't work if the Editor Link has %25l literal in it. I could "fix" it by adding '%25' => '%%325' conversion in loadEditorLink(), but it would still be wrong for %%25l...

epriestley accepted this revision.May 22 2014, 10:33 PM
epriestley edited edge metadata.

e h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h . . . okay

This revision is now accepted and ready to land.May 22 2014, 10:33 PM
epriestley closed this revision.May 22 2014, 10:33 PM
epriestley updated this revision to Diff 21998.

Closed by commit rP9bba4cda2fe5 (authored by @avivey, committed by @epriestley).

avivey added a comment.May 22 2014, 10:39 PM

Thanks!

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
3 lines
webroot/
rsrc/
js/
core/
5 lines

Diff 21913

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

webroot/rsrc/js/core/behavior-line-linker.js

Loading...
Phabricator · Built by Phacility