Page MenuHomePhabricator
Differential D9223

Added placeholder support to custom text fields
ClosedPublic
Actions

Authored by talshiri on May 20 2014, 8:09 PM.
Tags
None
Referenced Files
F14054260: D9223.diff
Fri, Nov 15, 11:40 PM
F14041243: D9223.diff
Mon, Nov 11, 4:58 PM
F14025813: D9223.diff
Thu, Nov 7, 8:33 PM
F13999348: D9223.diff
Thu, Oct 24, 2:18 PM
F13999331: D9223.id21906.diff
Thu, Oct 24, 2:14 PM
F13999327: D9223.id.diff
Thu, Oct 24, 2:11 PM
F13999324: D9223.id21922.diff
Thu, Oct 24, 2:10 PM
F13999318: D9223.id21974.diff
Thu, Oct 24, 2:08 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2133e610480e: Added placeholder support to custom text fields
Summary

placeholder text is pretty useful.

Test Plan

placeholder text is pretty useful. also fully supports not breaking everything.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 607
Build 607: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri updated this revision to Diff 21906.May 20 2014, 8:09 PM
talshiri retitled this revision from to Added placeholder support to custom text fields.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 20 2014, 8:09 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B607: Diff 21906.May 20 2014, 8:10 PM
epriestley requested changes to this revision.May 20 2014, 11:19 PM
epriestley edited edge metadata.

Let's:

  • Style the placeholders to the degree it's pratical;
  • Can we move the StandardField up a level?
  • Can textarea (remarkupcontrol) support it? If this is a mess, don't worry about it.
  • Mention it in the CustomField documentation.
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
57–65

I think we can move this up a level (to the parent)?

Can textareas also have placeholders?

This revision now requires changes to proceed.May 20 2014, 11:19 PM
talshiri updated this revision to Diff 21922.May 21 2014, 12:03 AM
talshiri edited edge metadata.

applied change requests

Herald added a reviewer: chad. · View Herald TranscriptMay 21 2014, 12:03 AM
Harbormaster completed remote builds in B617: Diff 21922.May 21 2014, 12:04 AM
epriestley accepted this revision.May 22 2014, 4:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 22 2014, 4:12 PM
epriestley closed this revision.May 22 2014, 4:12 PM
epriestley updated this revision to Diff 21974.

Closed by commit rP2133e610480e (authored by @talshiri, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
standard/
10 lines
view/
form/
control/
13 lines

Diff 21906

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php

Loading...
View Options

src/view/form/control/AphrontFormTextControl.php

Loading...
Phabricator · Built by Phacility