Dashboards - add remove functionality
ClosedPublic
Actions

Authored by btrahan on May 16 2014, 9:22 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5078: Clean up UltraDash++
T5084: Allow panels to be removed from a dashboard

Commits

Restricted Diffusion Commit
rPd9058d7f3ff7: Dashboards - add remove functionality

Summary

To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084.

Test Plan

removed some panels to much success

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 21749.May 16 2014, 9:22 PM

btrahan added a task: T5084: Allow panels to be removed from a dashboard.

btrahan retitled this revision from to Dashboards - add remove functionality.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 16 2014, 9:22 PM

Harbormaster completed remote builds in B513: Diff 21749.May 16 2014, 9:23 PM

This is HEADER_MODE_EDIT

Screen_Shot_2014-05-16_at_2.19.39_PM.png (1×2 px, 501 KB)

Yay hover state

Screen_Shot_2014-05-16_at_2.19.42_PM.png (1×2 px, 519 KB)

Clicked it

Screen_Shot_2014-05-16_at_2.19.45_PM.png (1×2 px, 481 KB)

Great success

Screen_Shot_2014-05-16_at_2.19.50_PM.png (1×2 px, 457 KB)

Works but should re-factor.

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
109	On second thought, I should do the opposite and put all this rendering code in here

re-jiggered code around

Harbormaster completed remote builds in B514: Diff 21750.May 16 2014, 10:51 PM

Cool, this looks good.

(One thing that might happens soon is letting PanelType add some icons to the header in "normal" mode, but we can address that in a variety of ways without changes here, and I think this is probably a cleaner architecture overall.)

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
88	(Unused, I think, per other comment.)
112	this miiiight be testing code
src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
5–14	Are these ever used?

This revision is now accepted and ready to land.May 17 2014, 12:13 AM

remove test code
remove un-used getter / setter
re-direct back to "arrange" view on panel edit if you cancel or submit the edit for super fast workfly happy action times