Page MenuHomePhabricator

Fix the `ArcanistXHPASTLinter` single quote rule.
ClosedPublic

Authored by joshuaspence on May 18 2014, 1:28 PM.
Tags
None
Referenced Files
F15417213: D9182.diff
Thu, Mar 20, 4:03 PM
F15415161: D9182.diff
Thu, Mar 20, 4:30 AM
F15379991: D9182.id.diff
Fri, Mar 14, 12:43 AM
F15344499: D9182.id21808.diff
Mon, Mar 10, 4:50 AM
Unknown Object (File)
Feb 11 2025, 7:19 PM
Unknown Object (File)
Feb 9 2025, 1:00 PM
Unknown Object (File)
Feb 9 2025, 1:00 PM
Unknown Object (File)
Feb 9 2025, 1:00 PM
Subscribers

Details

Summary

Previously, the ArcanistXHPASTLinter was suggesting that "\1" be written as '\1', which is incorrect. Therefore, I ensured that all of the cases listed in the PHP documentation were handled correctly.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-double_quotes
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 553
Build 553: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix the `ArcanistXHPASTLinter` single quote rule..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2014, 1:47 PM
epriestley updated this revision to Diff 21809.

Closed by commit rARC178b32c6c2d6 (authored by @joshuaspence, committed by @epriestley).