Paths

Table of Contentst

Differential D9182

Fix the `ArcanistXHPASTLinter` single quote rule.
ClosedPublic
Actions

Authored by joshuaspence on May 18 2014, 1:28 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC178b32c6c2d6: Fix the `ArcanistXHPASTLinter` single quote rule.

Summary

Previously, the ArcanistXHPASTLinter was suggesting that "\1" be written as '\1', which is incorrect. Therefore, I ensured that all of the cases listed in the PHP documentation were handled correctly.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

xhpast-double_quotes

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 553
Build 553: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21808.May 18 2014, 1:28 PM

joshuaspence retitled this revision from to Fix the `ArcanistXHPASTLinter` single quote rule..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2014, 1:28 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B553: Diff 21808.May 18 2014, 1:29 PM

epriestley accepted this revision.May 18 2014, 1:47 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 18 2014, 1:47 PM

Closed by commit rARC178b32c6c2d6 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

15 lines

__tests__/

xhpast/

double-quote.lint-test

6 lines

Diff 21808

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/double-quote.lint-test

Fix the `ArcanistXHPASTLinter` single quote rule.ClosedPublicActions