Differential D9149

Conpherence - fix send bug for users with no javascript
ClosedPublic
Actions

Authored by btrahan on May 16 2014, 2:25 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T5049: Problem: garbage output after sending to conpherence

Commits

Restricted Diffusion Commit
rP45f4431a844a: Conpherence - fix send bug for users with no javascript

Summary

we should do a redirect if its not an ajax request, which solves this problem since folks with no javascript aren't sending ajax requests. Fixes T5049.

Test Plan

inverted the predicate, tried ajax requests, and got redirected

Diff Detail

Repository

rP Phabricator

Branch

T5049

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 502
Build 502: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 21729.May 16 2014, 2:25 AM

btrahan added a task: T5049: Problem: garbage output after sending to conpherence.

btrahan retitled this revision from to Conpherence - fix send bug for users with no javascript.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 16 2014, 2:25 AM

Harbormaster completed remote builds in B502: Diff 21729.May 16 2014, 2:26 AM

epriestley accepted this revision.May 16 2014, 2:31 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 16 2014, 2:31 AM

Closed by commit rP45f4431a844a (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

2 lines

Diff 21729

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Conpherence - fix send bug for users with no javascriptClosedPublicActions