Page MenuHomePhabricator
Differential D9143

Allow dashboard panels to render in a headerless mode
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 9:18 PM.
Tags
None
Referenced Files
F17682831: D9143.id21730.diff
Sun, Jul 13, 10:11 PM
F17680924: D9143.id.diff
Sun, Jul 13, 5:42 PM
F17676032: D9143.id21712.diff
Sun, Jul 13, 9:39 AM
F17652325: D9143.diff
Sat, Jul 12, 6:38 AM
Unknown Object (File)
Tue, Jun 17, 7:22 AM
Unknown Object (File)
May 6 2025, 6:53 PM
Unknown Object (File)
Apr 24 2025, 10:39 PM
Unknown Object (File)
Apr 16 2025, 3:01 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rP302d5bcec5e7: Allow dashboard panels to render in a headerless mode
Summary

Ref T4986. This mostly just makes tab panels a little nicer.

Maybe this will be modal (header = "none", "edit", "view") in a few diffs but we can clean it up then if so.

Test Plan

Screen_Shot_2014-05-15_at_2.15.35_PM.png (141×862 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Branch
dash7
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 494
Build 494: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21712.May 15 2014, 9:18 PM
epriestley retitled this revision from to Allow dashboard panels to render in a headerless mode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 9:18 PM
Harbormaster completed remote builds in B494: Diff 21712.May 15 2014, 9:19 PM
chad accepted this revision.May 15 2014, 9:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 15 2014, 9:20 PM
epriestley closed this revision.May 16 2014, 2:31 AM
epriestley updated this revision to Diff 21730.

Closed by commit rP302d5bcec5e7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
dashboard/
controller/
1 line
engine/
41 lines
paneltype/
4 lines
1 line
webroot/
rsrc/
js/
application/
dashboard/
7 lines

Diff 21712

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
View Options

webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js

Loading...
Phabricator · Built by Phacility