Page MenuHomePhabricator

Fix `arc diff --raw` when run outside a repository
ClosedPublic

Authored by epriestley on May 15 2014, 8:46 PM.
Tags
None
Referenced Files
F19581293: D9142.id21711.diff
Sun, Feb 1, 6:48 PM
F19581291: D9142.id21721.diff
Sun, Feb 1, 6:46 PM
F19581285: D9142.diff
Sun, Feb 1, 6:45 PM
F19416250: D9142.id.diff
Dec 27 2025, 9:12 PM
F19356109: D9142.diff
Dec 26 2025, 6:58 AM
F19321269: D9142.id21711.diff
Dec 25 2025, 9:54 AM
F18905353: D9142.id21711.diff
Nov 8 2025, 1:55 PM
F18866280: D9142.id21711.diff
Nov 3 2025, 4:24 PM
Subscribers

Details

Summary

Fixes T5071. If you run arc diff --raw from some arbitrary, non-repository directory we incorrectly try to read information out of the working copy. Even if this information is available, arc diff --raw should not assume it's accurate (there's no guarantee the diff comes from the working copy).

Test Plan

Ran arc diff --raw in an arbitrary directory.

Diff Detail

Repository
rARC Arcanist
Branch
rawrepo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 493
Build 493: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix `arc diff --raw` when run outside a repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 2:02 AM
epriestley updated this revision to Diff 21721.

Closed by commit rARC75cb3cf35819 (authored by @epriestley).